Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User puck should rotate according to heading, not course #4069

Open
1ec5 opened this issue Aug 10, 2022 · 4 comments · May be fixed by #4129
Open

User puck should rotate according to heading, not course #4069

1ec5 opened this issue Aug 10, 2022 · 4 comments · May be fixed by #4129
Assignees
@jill-cardamon
Labels
bug Something isn’t working jira-sync-complete topic: location UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.
Milestone
v2.8

Comments

@1ec5
Copy link
Contributor

1ec5 commented Aug 10, 2022 •
edited
Loading

When following a walking route, the user puck should rotate according to the heading (the direction the device is facing), not the course (the direction in which the device is moving). Currently it always rotates according to the course, regardless of the routing profile:

mapbox-navigation-ios/Sources/MapboxNavigation/NavigationMapView.swift

Line 906 in 793a34f

mapView.location.options.puckBearingSource = .course

We should set LocationOptions.puckBearingSource to PuckBearingSource.heading when the current route’s profile identifier is walking. Unfortunately, this option is being set inside NavigationMapView, which doesn’t have much context about the route. We could set it based on one of the routes in routes, but maybe NavigationViewController should override it based on what it knows the current route to be.

The correct behavior for walking navigation was introduced in #3620, but it effectively regressed in #3123 when we delegated the responsibility for updating the puck’s location and direction to the map SDK without setting the puck bearing source.

/ref mapbox/mapbox-maps-ios#428
/cc @mapbox/navigation-ios @jinny-nam
@1ec5 1ec5 added bug Something isn’t working topic: location UI Work related to visual components, Android Auto, Camera, 3D, voice, etc. labels Aug 10, 2022
@MaximAlien
Copy link
Contributor

We also have issue with heading when using walking profile and when device is in landscape mode.

@MaximAlien MaximAlien added this to the v2.8 milestone Aug 22, 2022
@jill-cardamon
Copy link
Contributor

jill-cardamon commented Aug 22, 2022 •
edited
Loading

landscape mode related issue: #1942 (comment)

@jill-cardamon jill-cardamon linked a pull request Sep 6, 2022 that will close this issue
Open
@karldusenbery
Copy link

Hi, just checking in.
This ticket has been open for 4 months. Is there a plan to deliver a fix soon?

@karldusenbery
Copy link

Hi, just checking in.
This ticket has been open for 1 year. Is there a plan to deliver a fix soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jill-cardamon jill-cardamon

Labels
bug Something isn’t working jira-sync-complete topic: location UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.
Projects
None yet
Milestone
v2.8
Development

Successfully merging a pull request may close this issue.

User puck rotates according to heading for walking profile mapbox/mapbox-navigation-ios
5 participants
@1ec5 @MaximAlien @karldusenbery @truburt @jill-cardamon