Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: UserPuckCourseView moves to incorrect position after map view panning. #3952

Closed
MaximAlien opened this issue Jun 15, 2022 · 3 comments · Fixed by #3988 · May be fixed by #3953
Closed

[Bug]: UserPuckCourseView moves to incorrect position after map view panning. #3952

MaximAlien opened this issue Jun 15, 2022 · 3 comments · Fixed by #3988 · May be fixed by #3953
Assignees
@MaximAlien
Labels
bug Something isn’t working UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.

Comments

@MaximAlien
Copy link
Contributor

Mapbox Navigation SDK version

main

Steps to reproduce

  1. Set navigationMapView.userLocationStyle = .courseView().
  2. Start example application and pan map view.
  3. Observe behavior.

Expected behavior

UserPuckCourseView shouldn't move to -1.0, -1.0 position.

Actual behavior

UserPuckCourseView shouldn't move to position: -1.0, -1.0. For example:

Screen.Recording.2022-06-15.at.3.09.43.PM.mov

Is this a one-time issue or a repeatable issue?

repeatable
@MaximAlien MaximAlien added bug Something isn’t working UI Work related to visual components, Android Auto, Camera, 3D, voice, etc. labels Jun 15, 2022
@MaximAlien MaximAlien linked a pull request Jun 15, 2022 that will close this issue
Add testMapViewPointForCoordinate. #3953
Open
@MaximAlien
Copy link
Contributor Author

One of the possible fixes can be to hide puck completely if it's outside of the bounding box.

@MaximAlien MaximAlien self-assigned this Jun 27, 2022
@impresyjna
Copy link

Other solution could be changing userStyle after interaction for example for puck2D

@MaximAlien MaximAlien mentioned this issue Jul 6, 2022
Merged
@MaximAlien MaximAlien linked a pull request Jul 6, 2022 that will close this issue
Hide user course view in case if current user location coordinate point is invalid. #3988
Merged
@MaximAlien
Copy link
Contributor Author

Current issue is a regression after implementing mapbox/mapbox-maps-ios#1195.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaximAlien MaximAlien

Labels
bug Something isn’t working UI Work related to visual components, Android Auto, Camera, 3D, voice, etc.
Projects
None yet
Milestone
No milestone
2 participants
@MaximAlien @impresyjna