-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Similar plugin #24
Comments
it looks like your readme hasn't changed that much since you began your fork, could you describe the current state of your plugin and its features? Then concerning "combining our efforts", why not, but it looks like our projects are quite different, mainly because mine can use pandoc to convert from MD to HTML What needs work in my plugin is:
And what works fine is:
|
Some other people and myself tried to get the original maintainer to respond to pull requests and issues for several years - without success. I updated the README to the current state (only the pictures are a bit outdated). See my release announcement on what has changed in the last days. Features
Missing features
I see my plugin as a lightweight preview and therefore would prefer not to have a hard dependency on |
it's not a hard dependency, most of the useless complexity of my code actually comes from managing cases where there is only python3-markdown but not pandoc, or the opposite |
What about wrapping the rendering part behind a common interface? Then you just have to call In my code the rendering is a single call to |
that would be worse imho: the rendering part is simple enough to be a single if, while the several GUIs have nothing in common, so doing a generic interface would be more complicated anyway my code is uselessly spaghetti but it works quite well (except the 3 things i listed) i'll probably add support for GtkSource's LanguageManager, i didn't do it at first for some reason i forgot, but i'm sure this reason isn't valid anymore |
One downside is the case when the file isn't saved already, one has to select the language manually. But in this case, your detection by file extension fails as well anyways. One thing I didn't get working is having the preview stay at the same position after refresh. |
To get it working i had to run some javasript in the webview, search "javascript" in preview.py However i connected the methods to the first random signals that kinda worked, i think there are improvements to do lol |
Thanks for this idea! Unfortunately, I couldn't find any better signals as well... |
I just released a fixed version of the
gedit-markdown
plugin: https://github.com/darkdragon-001/gedit-markdownWould you like to combine our efforts?
The text was updated successfully, but these errors were encountered: