Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MantraJS-atom vs Mantra-CLI #28

Open
nadeemja opened this issue May 27, 2016 · 3 comments
Open

MantraJS-atom vs Mantra-CLI #28

nadeemja opened this issue May 27, 2016 · 3 comments

Comments

@nadeemja
Copy link

Hi,

It appears that MantraJS-atom and Mantra-CLI are in disagreement about a few things.

  1. Mantra-atom creates index.js, while mantra-cli creates main.js in server and client folders.
    Using both Mantra-atom and Mantra-CLI therefore causes duplication errors for methods and publications in meteor server.
  2. Mantra-atom requires ./configs/config in client/index.js (which it doesn't create and causes unable to resolve type errors), whereas Mantra CLI creates and requires ./configs/context
  3. Mantra-atom adds file routes.js to core-module. Mantra CLI does not.

There might be other incongruencies.

Please advise on what we should do. :)

PS. Thanks for two awesome tools. My life has improved <3

@macrozone
Copy link
Contributor

Maybe the atom-package could use mantrajs-cli under the hood?

Can't say much about the 3 disagreements though. I think the mantra-sample application is the best guideline here

@tomitrescak
Copy link
Contributor

If you read docs, the mantra atom package is fully configurable via yaml file, whatever you do not like can be changed with no hassle. You can change file names, file contents, directories, even add or reorganise panes. This is not possible with cli package. If you feel that these changes would benefit the whole community, just create a PR, like the recent one which changed stories folder to .stories folder.

@macrozone
Copy link
Contributor

@tomitrescak , yeah the atom-package's yaml configs are great! Would be cool if the cli could use the same templates. @sungwoncho 's idea of having a .mantra-config-folder sounds also promising: https://talk.mantrajs.com/t/do-we-have-to-use-the-mantra-generated-eslintrc/178/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants