Show residuals during reconstruction #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call back that records the residual for PDHG
samtygier-stfc
force-pushed
the
2369-residuals
branch
from
0bdeb34 to
36cc881
Compare
samtygier-stfc
force-pushed
the
2369-residuals
branch
from
36cc881 to
d8a7eae
Compare
JackEAllen
reviewed
Dec 11, 2024
JackEAllen
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2369
Description
Add a callback to record residuals from PDHG.
Add an ImageView to the async dialog to show the residuals
Testing
Describe the tests that were used to verify your changes.
Acceptance Criteria
Run PDHG with enough iterations to show the dialog
Documentation
Release notes