fixed comp warnings

mantidproject · Nov 22, 2024 · 8f83b5c · 8f83b5c
1 parent 7c3e5cc
commit 8f83b5c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/Framework/DataObjects/inc/MantidDataObjects/PeakShapeDetectorBin.h b/Framework/DataObjects/inc/MantidDataObjects/PeakShapeDetectorBin.h
@@ -30,7 +30,7 @@ class MANTID_DATAOBJECTS_DLL PeakShapeDetectorBin : public PeakShapeBase {
   std::string shapeName() const override;
 
   /// PeakBase interface
-  std::optional<double> radius(RadiusType type = RadiusType::Radius) const override;
+  std::optional<double> radius(RadiusType) const override { return std::nullopt; }
 
   static const std::string detectorBinShapeName();
 

diff --git a/Framework/DataObjects/src/PeakShapeDetectorBin.cpp b/Framework/DataObjects/src/PeakShapeDetectorBin.cpp
@@ -55,8 +55,6 @@ Mantid::Geometry::PeakShape *PeakShapeDetectorBin::clone() const { return new Pe
 
 std::string PeakShapeDetectorBin::shapeName() const { return PeakShapeDetectorBin::detectorBinShapeName(); }
 
-std::optional<double> PeakShapeDetectorBin::radius(RadiusType type) const { return std::nullopt; }
-
 const std::string PeakShapeDetectorBin::detectorBinShapeName() { return "PeakShapeDetectorBin"; }
 
 } // namespace Mantid::DataObjects
diff --git a/Framework/DataObjects/src/PeakShapeDetectorBinFactory.cpp b/Framework/DataObjects/src/PeakShapeDetectorBinFactory.cpp
@@ -33,7 +33,7 @@ Mantid::Geometry::PeakShape *PeakShapeDetectorBinFactory::create(const std::stri
 
       std::vector<std::tuple<int32_t, double, double>> detectorBinList;
       const Json::Value detectorList = root["detectors"];
-      for (int index = 0; index < detectorList.size(); index++) {
+      for (uint32_t index = 0; index < detectorList.size(); index++) {
         const Json::Value detBinVal = detectorList[index];
         detectorBinList.emplace_back(detBinVal["detId"].asInt(), detBinVal["startX"].asDouble(),
                                      detBinVal["endX"].asDouble());