Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholders support for --path option #85

Closed
kesinger opened this issue Jul 16, 2023 · 2 comments
Closed

Add placeholders support for --path option #85

kesinger opened this issue Jul 16, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@kesinger
Copy link

The idea

It would be convenient if there were an option that I could set to change the "Vol " (and "No Volume") of filename construction here:

https://github.com/mansuf/mangadex-downloader/blob/28ba4b326df806f2baec9568595d89c018211258/mangadex_downloader/format/base.py#L252C13-L252C33

Why this feature should be added to the app ?

I view dl'd manga on a tablet, and if I transfer two different manga on there I'll have two "Vol 1.epub", two "Vol 2.epub", and so on. If I could specify the currently-fixed part of the file name I could have saved them as "Manga 1 Vol 1.epub", "Manga 2 Vol 1.epub", etc, and be able to tell which is which from the filename.

(I understand this is ultimately a problem with some other piece of software, and it's easy enough for me to write a little script to rename things, but it never hurts to ask...)

@kesinger kesinger added the enhancement New feature or request label Jul 16, 2023
@mansuf mansuf mentioned this issue Jul 17, 2023
29 tasks
@mansuf
Copy link
Owner

mansuf commented Jul 17, 2023

This feature currently planned in v3.0.0. You can check the progress in here #80

I will notify you when this feature is finished and ready to test.

@mansuf mansuf changed the title Add option to get_volume_name Add placeholders support for --path option Jul 17, 2023
@mansuf
Copy link
Owner

mansuf commented Dec 18, 2023

Hello, sorry for taking so long, i got too busy in real life things.

Anyways, this feature has been added in v3.0.0 branch (commit 3e257fb)

You can start trying it now by installing development version (v3.0.0 branch)

Installation with git + pip:

pip uninstall mangadex-downloader
pip install git+https://github.com/mansuf/mangadex-downloader.git@3e257fb5264c6e46ecb23ac1e45eb8f269d257f1

If you're installing mangadex-downloader from github releases, you can download the development version in here:

The download files are available in "artifacts" section

https://github.com/mansuf/mangadex-downloader/actions/runs/7248099641


--path option are now absolute and you can use placeholders so you can customize as you like it.

Example usage:

# This will download to directory "/home/sussyuser/manga/Some manga title - some_random_id/English"
mangadex-dl "URL" --path "/home/sussyuser/manga/{manga.title} - {manga.id}/{language.full}" -lang English

For more information about path placeholders, you can read the documentation here -> https://mangadex-dl.mansuf.link/en/v3.0.0/cli_ref/path_placeholders.html

If you have a problem just let me know.

@mansuf mansuf closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants