Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when adding node to nodelist in meshping.pde #11

Open
ve2yag opened this issue Oct 22, 2013 · 0 comments
Open

Bug when adding node to nodelist in meshping.pde #11

ve2yag opened this issue Oct 22, 2013 · 0 comments

Comments

@ve2yag
Copy link

ve2yag commented Oct 22, 2013

I check your code and see this:

// If this message is from ourselves or the base, don't bother adding it to the active nodes.
if ( header.from_node != this_node || header.from_node > 00 )
add_node(header.from_node);
}

I think this is correct line, because the node add himself to list anyway (because >0)

// If this message is from ourselves or the base, don't bother adding it to the active nodes.
if ( header.from_node != this_node && header.from_node != 00 )
add_node(header.from_node);
}

If node != itself AND node != 0 then addnodetolist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant