build: Update to fmt 10 #1427
Merged
build: Update to fmt 10 #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <[email protected]>
One need to update vcpkg to use 10.2.1. Signed-off-by: Julien Jerphanion <[email protected]>
Co-authored-by: Vasil Danielov Pashov <[email protected]> Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
willdealtry
approved these changes
Mar 15, 2024
Reason: spdlog depends on fmt. Signed-off-by: Julien Jerphanion <[email protected]>
vasil-pashov
pushed a commit
that referenced
this pull request
Mar 15, 2024
This reverts commit 75b14e1. This commit breaks MSVS builds. Abseil package fails to build.
grusev
pushed a commit
that referenced
this pull request
Nov 25, 2024
Signed-off-by: Julien Jerphanion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Pre-requisite for #1417.
What does this implement or fix?
Any other comments?
fmt 10.2.1 is available on vcpkg, this necessitate updating vcpkg as proposed by 8f04091.
Checklist
Checklist for code changes...