Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression when requesting a timestamp before the earliest version #1772

Open
willdealtry opened this issue Aug 16, 2024 · 0 comments · May be fixed by #2076
Open

Performance regression when requesting a timestamp before the earliest version #1772

willdealtry opened this issue Aug 16, 2024 · 0 comments · May be fixed by #2076
Assignees
Labels
bug Something isn't working

Comments

@willdealtry
Copy link
Collaborator

Describe the bug

In the ASV benchmark time_read_from_epoch, we preload the cache back to the beginning, but then ask for an as_of time that is earlier than any versions. I think previously given that the cache hasn't expired we would detect that the prior load was a LOAD_ALL and not reload it, because LOAD_ALL trumps everything. However now we're just looking at the earliest loading time, seeing that the requested time is before that and ignoring the fact that we loaded everything recently, so there's no point doing it again.

Steps/Code to Reproduce

Why do I have to fill in all these boxes?

Expected Results

It is less slow

OS, Python Version and ArcticDB Version

more boxes

Backend storage used

Seriously?

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants