From f24449b1aeeeb47e97f217afda8d517bac480e51 Mon Sep 17 00:00:00 2001 From: Ivo Dilov Date: Tue, 5 Nov 2024 17:06:49 +0200 Subject: [PATCH] Re comments on #1979 we skip the lmdb compat tests as well After we fix the segfaults we can re-enable --- python/tests/compat/conftest.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/python/tests/compat/conftest.py b/python/tests/compat/conftest.py index d9a3bb0ce8..202b5f8117 100644 --- a/python/tests/compat/conftest.py +++ b/python/tests/compat/conftest.py @@ -182,13 +182,12 @@ def arctic_uri(request): @pytest.fixture() def old_venv_and_arctic_uri(old_venv, arctic_uri): + # TODO: Once #1979 is understood and fixed reenable mongo, lmdb and azure for versions which have the fix. if arctic_uri.startswith("mongo"): - # TODO: We tought the bug was fixed in 4.5.1 but it's still present. - pytest.skip("Mongo storage backend has a desctruction bug, which can cause flaky segfaults.") - if Version(old_venv.version) <= Version("4.5.0") and arctic_uri.startswith("lmdb"): - pytest.skip("LMDB storage backend has a desctruction bug present until 4.5.0, which can cause flaky segfaults.") + pytest.skip("Mongo storage backend has a probable desctruction bug, which can cause flaky segfaults.") + if arctic_uri.startswith("lmdb"): + pytest.skip("LMDB storage backend has a probable desctruction bug, which can cause flaky segfaults.") if arctic_uri.startswith("azure"): - # TODO: Once #1979 is understood and fixed reenable azure on versions which have the fix. pytest.skip("Azure storage backend has probable a desctruction bug, which can cause flaky segfaults.") return old_venv, arctic_uri