From e8508805248eb38faedca65f4f6a7d9c56c1a4b5 Mon Sep 17 00:00:00 2001 From: phoebusm Date: Fri, 20 Dec 2024 12:21:12 +0000 Subject: [PATCH] Update requirement --- setup.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 83e93a778d..b95edf3bc8 100644 --- a/setup.py +++ b/setup.py @@ -34,7 +34,7 @@ def _log_and_run(*cmd, **kwargs): class CompileProto(Command): # When adding new protobuf versions, also update: setup.cfg, python/arcticdb/__init__.py - _PROTOBUF_TO_GRPC_VERSION = {"3": "<1.31", "4": ">=1.66.2", "5": ">=1.68.1"} + _PROTOBUF_TO_GRPC_VERSION = {"3": "<1.31", "4": ">=1.49", "5": ">=1.68.1"} description = '"protoc" generate code _pb2.py from .proto files' user_options = [ @@ -74,6 +74,10 @@ def run(self): # Not compatible with Python<=3.7 as # GRPCIO >= 1.64.0 is not available on Python<=3.7 https://pypi.org/project/grpcio-tools/1.64.0/#files print(f"Python protobuf {proto_ver} does not run on Python {python}. Skipping...") + elif not ARCTICDB_USING_CONDA and python >= (3, 13) and proto_ver < "5": + # Not compatible with protobuf<5.26.1 as + # Python 3.13 requires GRPCIO >= 1.66.2, which requires protobuf >=5.26.1 https://github.com/grpc/grpc/blob/6fa8043bf9befb070b846993b59a3348248e6566/requirements.txt#L4 + print(f"Python protobuf {proto_ver} does not run on Python {python}. Skipping...") else: self._compile_one_version(proto_ver, os.path.join(output_dir, proto_ver))