Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: WasteNet Southland url has changed #1718

Closed
4 of 7 tasks
etamtlosz opened this issue Jan 25, 2024 · 4 comments · Fixed by #1798
Closed
4 of 7 tasks

[Bug]: WasteNet Southland url has changed #1718

etamtlosz opened this issue Jan 25, 2024 · 4 comments · Fixed by #1798
Labels
source defect Defect of a source reported

Comments

@etamtlosz
Copy link

I Have A Problem With:

A specific source

What's Your Problem

The url for wastenet southland has changed. It looks like they published a new website.
The search form has moved here -> https://www.wastenet.org.nz/bin-day/
The results look like this -> https://www.wastenet.org.nz/bin-day/?entry_id=3554

The search form is sometimes a PITA, spitting out multiple addresses after pressing search, but if one knows his ID, like 3554, then the search result spits out the right result.

Source (if relevant)

wastenet_org_nz

Logs

No response

Relevant Configuration

No response

Checklist Source Error

  • Use the example parameters for your source (often available in the documentation) (don't forget to restart Home Assistant after changing the configuration)
  • Checked that the website of your service provider is still working
  • Tested my attributes on the service provider website (if possible)
  • I have tested with the latest version of the integration (master) (for HACS in the 3 dot menu of the integration click on "Redownload" and choose master as version)

Checklist Sensor Error

  • Checked in the Home Assistant Calendar tab if the event names match the types names (if types argument is used)

Required

  • I have searched past (closed AND opened) issues to see if this bug has already been reported, and it hasn't been.
  • I understand that people give their precious time for free, and thus I've done my very best to make this problem as easy as possible to investigate.
@5ila5
Copy link
Collaborator

5ila5 commented Jan 27, 2024

Do you see any way to get some real dates?

For something like Collection Day: Friday; Frequency: Weekly we can generate the dates, but do you see a way to get the actual weeks for something like Collection Day: Friday Frequency: Fortnightly?

@5ila5 5ila5 added the source defect Defect of a source reported label Jan 27, 2024
@etamtlosz
Copy link
Author

etamtlosz commented Jan 29, 2024

I've been in contact with wastenet and they are still working on the database. It feels like they have pushed an alpha version to public.

The PDF below the search box shows the weeks in yellow for the "recycling".
One issue could arise due to public holidays, when the collection day is delayed by one day. For example if we had a public holiday on Tuesday, then every pickup day during that week (after Tuesday) gets shifted to the next day. I my example Friday becomes Saturday.

@etamtlosz
Copy link
Author

Looks like I managed to convince them how important the date and the day of the week + the presence of the text TOMORROW/TODAY is.
I think the script needs just a slight code adjustment.

@etamtlosz etamtlosz changed the title [Bug]: WasteNet Southlandurl has changed [Bug]: WasteNet Southland url has changed Feb 14, 2024
@5ila5
Copy link
Collaborator

5ila5 commented Feb 17, 2024

Fixed the source in #1798

This will be part of release 1.46.0 or is available now as master (git) version (3-dot menu -> redownload -> change version to master -> fully restart HA (this will increase update cycle by a lot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source defect Defect of a source reported
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants