Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Don't display the Account menu option when not logged in #10

Open
liamquinn14 opened this issue Nov 19, 2024 · 3 comments
Open
Labels
wontfix This will not be worked on

Comments

@liamquinn14
Copy link
Collaborator

Version

v3

Impact

Medium

Suggested Priority

Medium

Description

For users who aren't logged in, clicking on the Account page renders an error message. The menu bar disappears meaning that users have to press 'back' in their browser to return back to the full site. Therefore, we should remove the Account link from the menu bar for users who aren't logged in, so that we don't have an unnecessary link that only causes extra problems.

@PaulNGilson PaulNGilson added the wontfix This will not be worked on label Nov 19, 2024
@PaulNGilson
Copy link
Contributor

This looks like it goes against what the spec is asking for cf. DE006 which asks for inaccessibility not hidden. But we will certainly look into the issue with navigation - need some 401 handling for inaccessible pages due to no authorisation.

@neilstudd
Copy link
Contributor

This one's my fault - see comments on #5 , I've been too busy looking at CSS/styling so I forgot to check back in the spec before I suggested that Liam raises it!

whoopsie-doodle

@liamquinn14
Copy link
Collaborator Author

I concede that the spec doesn't require the Account link to be hidden, but I think for the reasons that myself and Neil discussed in #5 , we should request to update the specification to cater for this requirement. It would certainly improve the quality of the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants