Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngx_http_graphite_ssl_session_reused breaks nginx tests #54

Open
hfrog opened this issue Dec 29, 2023 · 0 comments
Open

ngx_http_graphite_ssl_session_reused breaks nginx tests #54

hfrog opened this issue Dec 29, 2023 · 0 comments

Comments

@hfrog
Copy link

hfrog commented Dec 29, 2023

Hello,
I've noticed that this part of code breaks nginx tests

#if (NGX_SSL)
static ngx_int_t
ngx_http_graphite_ssl_session_reused(ngx_http_request_t *r, ngx_http_variable_value_t *v, uintptr_t data) {

    ngx_str_t s;

    if (r->connection->requests == 1) {
        if (r->connection->ssl && SSL_session_reused(r->connection->ssl->connection)) {
            ngx_str_set(&s, "yes");
        }
        else {
            ngx_str_set(&s, "no");
        }
    }
    else {
        ngx_str_set(&s, "none");
    }

This is because nginx have the same variable $ssl_session_reused, but it has values 'r'/'.' instead of 'yes'/'no'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant