You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change all line endings to lf upstream. This is the requirement stated in the .editorconfig file anyways.
Motivation
My work for #5127 was made difficult by diverging CRLF settings of files in the repo. I would suggest to fix the upstream linebreak settings of all files and use git config core.autcrlf true locally.
Additional context
Output of git ls-files --eol | grep -v -E '^(i\/lf|i\/none|i\/-text)'
As most of the code is most of the times run on Linux (which uses LF), most of the repo is already LF, and LF being the de-facto standard in most larger git repos, I think the only sensible choice is LF.
When checking out on windows, core.autocrlf true is handling all problems completely frictionless. Having some files in CRLF, and some even with MIXED line endings is literally the worst state a code base can be in.
Summary
Change all line endings to lf upstream. This is the requirement stated in the .editorconfig file anyways.
Motivation
My work for #5127 was made difficult by diverging CRLF settings of files in the repo. I would suggest to fix the upstream linebreak settings of all files and use
git config core.autcrlf true
locally.Additional context
Output of
git ls-files --eol | grep -v -E '^(i\/lf|i\/none|i\/-text)'
The text was updated successfully, but these errors were encountered: