Added certificate renew option with old key or new key, and update TLSA record accordingly #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atch-1 � Conflicts: � CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing mail-in-a-box software doesn't have any options for renewing the current key or get a certificate with a new key. It creates a key pair initially and uses this key during the whole lifetime of the setup. If any user updates the key manually, he or she will have to manually change the certificates and TLSA records which is error-prone.
This update provides an option to renew the cert for the user with both the existing key and with a new key and if the user does so with a new key, then update the TLSA records using the Double TLSA scheme (https://mail.sys4.de/pipermail/dane-users/2018-February/000440.html). The main motivation for doing this is to reduce the number of misconfigurations due to manual key rollover.
Comments welcome.