Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Futher improve the test coverage #59

Open
maqi opened this issue Jan 4, 2021 · 0 comments
Open

Futher improve the test coverage #59

maqi opened this issue Jan 4, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@maqi
Copy link
Member

maqi commented Jan 4, 2021

The current coverage report only shows a test coverage of 50%.

We may need more tests to cover changing membership, but with simple net setup and not requiring qp2p.

as a note, the previous tests using members doesn't contribute to the test coverage.

For reference, we could have a look at https://github.com/dan-da/brb/blob/master/src/net.rs.
With some usage/tests are in: https://github.com/dan-da/brb_dt_orswot/blob/master/tests/brb_orswot_net.rs
for a fake network testing.

@maqi maqi added the enhancement New feature or request label Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant