Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment about detail on the docs #36

Open
ferchaure opened this issue Jun 25, 2021 · 0 comments
Open

Comment about detail on the docs #36

ferchaure opened this issue Jun 25, 2021 · 0 comments

Comments

@ferchaure
Copy link

Hi Jeremy, just a comment about the relationship between adjacency_radius and a geometry file with zeros.

The description of the parameter adjacency_radius (on p_ms4alg.py line 31) says:
0 means each channel is sorted independently.

And I thought that was always true. But reading the function get_channel_neighborhood, I understand that even with adjacency_radius=0 all the channels will be sorted together if a geometry with all zeros is used. Maybe a clarification should be included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant