Merge pull request #61 from rafaelhl/skip-ignored-private-field

Skip ignored private fields
magiconair · Dec 7, 2024 · d8bdba3 · d8bdba3
2 parents d80fb15 + 9c90def
commit d8bdba3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/decode.go b/decode.go
@@ -189,12 +189,12 @@ func dec(p *Properties, key string, def *string, opts map[string]string, v refle
 		for i := 0; i < v.NumField(); i++ {
 			fv := v.Field(i)
 			fk, def, opts := keydef(t.Field(i))
-			if !fv.CanSet() {
-				return fmt.Errorf("cannot set %s", t.Field(i).Name)
-			}
 			if fk == "-" {
 				continue
 			}
+			if !fv.CanSet() {
+				return fmt.Errorf("cannot set %s", t.Field(i).Name)
+			}
 			if key != "" {
 				fk = key + "." + fk
 			}

diff --git a/decode_test.go b/decode_test.go
@@ -213,11 +213,12 @@ func TestDecodeArrayDefaults(t *testing.T) {
 
 func TestDecodeSkipUndef(t *testing.T) {
 	type S struct {
+		p     string `properties:"-"`
 		X     string `properties:"-"`
 		Undef string `properties:",default=some value"`
 	}
 	in := `X=ignore`
-	out := &S{"", "some value"}
+	out := &S{"", "", "some value"}
 	testDecode(t, in, &S{}, out)
 }