Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate library to TypeScript #51

Open
rain-sk opened this issue Jan 22, 2019 · 7 comments
Open

Translate library to TypeScript #51

rain-sk opened this issue Jan 22, 2019 · 7 comments

Comments

@rain-sk
Copy link

rain-sk commented Jan 22, 2019

@duivvv Thanks for your note about collaborating. I'm opening this issue to track the work.

I have done some work on my fork. With your permission, I'll merge these changes to a branch on this repository for testing and review.

@geoffreydhuyvetters
Copy link
Member

Hey @spencerudnick, yeah please feel free to do so.

Also: can we make the types available somehow for consumers of the lib, do you have any idea on how that could work?

@geoffreydhuyvetters
Copy link
Member

Can you sync it to the next-release one? (open a PR to merge into it)
I would love to look into a babel/TypeScript setup as described here https://iamturns.com/typescript-babel/

Only use TypeScript for the actual typing.

@rain-sk
Copy link
Author

rain-sk commented Jan 22, 2019 via email

@rain-sk
Copy link
Author

rain-sk commented Jan 22, 2019 via email

@rain-sk
Copy link
Author

rain-sk commented Jan 23, 2019

I've started with the conversion based on the link you provided, nice way to develop with TypeScript without using it to compile.

I'm noticing some redundancies after the conversion, so I'll fix those up first.

@skulptur
Copy link

skulptur commented Jan 4, 2021

Hey guys, I'm interested in a conversion happening. I've used TSDX in a bunch of projects, might be a good fit here. https://github.com/formium/tsdx

@geoffreydhuyvetters
Copy link
Member

I might do a big refactor in the future. I always had the idea of creating an internal circle of fifths and take everything from there. Interested in joining?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants