Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chord progressions #27

Open
geoffreydhuyvetters opened this issue Mar 16, 2018 · 7 comments
Open

Chord progressions #27

geoffreydhuyvetters opened this issue Mar 16, 2018 · 7 comments
Labels
question Further information is requested

Comments

@geoffreydhuyvetters
Copy link
Member

geoffreydhuyvetters commented Mar 16, 2018

any idea on how we could handle chord progressions?

https://en.wikipedia.org/wiki/Chord_progression

@geoffreydhuyvetters geoffreydhuyvetters changed the title how can we handle chord progressions? Chord progressions Mar 16, 2018
@geoffreydhuyvetters geoffreydhuyvetters added the question Further information is requested label Mar 16, 2018
@enjikaka
Copy link

enjikaka commented Jan 14, 2019

I've done the basics of this on https://plypp.net. There it's basically just a switch case returning the intervals (as midi number) between the root and the rest of the keys in the chord.

@geoffreydhuyvetters
Copy link
Member Author

Need to re-write the intervals a bit first, thank for the help :)

@enjikaka
Copy link

Oh, read a bit closer now. This was about progression 🙈
I see music-fns already has some chords; done very similar to how I did it on Plypp! I do have some more chords though. Can make a PR for that if we want that in here? (And I can refactor my code out and use music-fns instead! )

@geoffreydhuyvetters
Copy link
Member Author

That would be awesome :)
Feel free to do so.

@enjikaka
Copy link

enjikaka commented Jan 14, 2019

I don't quite get the naming in this repo though. Using the naming convention of MINOR_MAJOR_SEVENTH and MAJOR_SEVENTH etc will become very cumbersome when we do sus2, sus7, add11 etc. Can we just name them like they are in regular notation? Chord['sus2'] instead of Chord.SUSPENDED_SECOND?

@geoffreydhuyvetters
Copy link
Member Author

Hmm, not sure. In the case of suspended, I get it.

But I think MAJOR / MINOR etc should be possible, no?
We could create aliases Like I did for the intervals?

@enjikaka
Copy link

@duivvv Made a proposal here: #50 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants