Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anchorPattern matches inner parens pairs #12

Open
DivineDominion opened this issue Jul 24, 2017 · 1 comment
Open

anchorPattern matches inner parens pairs #12

DivineDominion opened this issue Jul 24, 2017 · 1 comment

Comments

@DivineDominion
Copy link
Contributor

Just noticed that anchorPattern is seemingly supposed to match [title][anchor]-style links while anchorInlinePattern matches [title](http://example.com)-style links.

Still, anchorPattern uses parenRegex to match round parens on its inside.

Thinking about it, I would simply remove that part. Was there an edge case you wanted to handle with that code, @macteo? If so, I'll write tests for that case to make sure that no refactoring breaks the existing stuff.

@macteo
Copy link
Owner

macteo commented Aug 11, 2017

It can be definitely removed as far as I understand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants