forked from zerebubuth/openstreetmap-license-change
-
Notifications
You must be signed in to change notification settings - Fork 1
/
test_references.rb
executable file
·350 lines (316 loc) · 13.8 KB
/
test_references.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
#!/usr/bin/env ruby
require './change_bot'
require './user'
require './changeset'
require './db'
require './actions'
require './util.rb'
require 'minitest/unit'
class TestReferences < MiniTest::Unit::TestCase
##
# this tests that a clean way may have to be deleted if it contains
# unclean nodes and these nodes are deleted, leaving the way with
# too few nodes to be valid any more.
#
def test_cascading_way_deletion
db = DB.new(:changesets => {
1 => Changeset[User[true]],
2 => Changeset[User[true]],
3 => Changeset[User[false]]
},
:nodes => {
# we'll have to delete this
1 => [OSM::Node[[0,0], :id => 1, :changeset => 3, :version => 1]],
# but this one is OK
2 => [OSM::Node[[1,1], :id => 2, :changeset => 1, :version => 1]]
},
:ways => {
# loses a node, which makes it invalid and will have to be deleted.
1 => [OSM::Way[[1,2], :id => 1, :changeset => 2, :version => 1]]
})
bot = ChangeBot.new(db)
bot.process_all!
assert_equal([Delete[OSM::Way, 1],
Delete[OSM::Node, 1]
],
bot.as_changeset)
end
##
# this tests that a clean way may have to be edited, even though
# it's clean, because an unclean node is deleted and cannot be
# referenced any more.
#
def test_remove_dirty_node_from_way
db = DB.new(:changesets => {
1 => Changeset[User[true]],
2 => Changeset[User[true]],
3 => Changeset[User[false]]
},
:nodes => {
# we'll have to delete this
1 => [OSM::Node[[0,0], :id => 1, :changeset => 3, :version => 1]],
# but these ones are OK
2 => [OSM::Node[[1,1], :id => 2, :changeset => 1, :version => 1]],
3 => [OSM::Node[[1,1], :id => 3, :changeset => 1, :version => 1]]
},
:ways => {
# despite the clean-ness of this one it will have to be edited to
# get rid of the node which will be deleted because it's unclean.
1 => [OSM::Way[[1,2,3], :id => 1, :changeset => 2, :version => 1]]
})
bot = ChangeBot.new(db)
bot.process_all!
assert_equal([Edit[OSM::Way[[2,3], :id => 1, :changeset => -1, :version => 1]],
Delete[OSM::Node, 1]
],
bot.as_changeset)
end
##
# this tests removing an unclean node from a way, where the node
# is at the same time the first and last node in the way.
#
def test_remove_dirty_node_from_way_twice
db = DB.new(:changesets => {
1 => Changeset[User[true]],
2 => Changeset[User[true]],
3 => Changeset[User[false]]
},
:nodes => {
# we'll have to delete this
1 => [OSM::Node[[0,0], :id => 1, :changeset => 3, :version => 1]],
# but these ones are OK
2 => [OSM::Node[[1,1], :id => 2, :changeset => 1, :version => 1]],
3 => [OSM::Node[[1,1], :id => 3, :changeset => 1, :version => 1]]
},
:ways => {
# despite the clean-ness of this one it will have to be edited to
# get rid of the node which will be deleted because it's unclean.
1 => [OSM::Way[[1,2,3,1], :id => 1, :changeset => 2, :version => 1]]
})
bot = ChangeBot.new(db)
bot.process_all!
assert_equal([Edit[OSM::Way[[2,3], :id => 1, :changeset => -1, :version => 1]],
Delete[OSM::Node, 1]
],
bot.as_changeset)
end
##
# this tests removing two nodes from a way - one clean node that was added
# by a decliner, and one unclean node that was added by an agreer!
#
def test_remove_two_nodes_from_way_for_different_reasons
db = DB.new(:changesets => {
1 => Changeset[User[true]],
2 => Changeset[User[true]],
3 => Changeset[User[false]]
},
:nodes => {
# we'll have to delete this
1 => [OSM::Node[[0,0], :id => 1, :changeset => 3, :version => 1]],
# but these ones are OK
2 => [OSM::Node[[1,1], :id => 2, :changeset => 1, :version => 1]],
3 => [OSM::Node[[1,1], :id => 3, :changeset => 1, :version => 1]],
4 => [OSM::Node[[1,1], :id => 4, :changeset => 1, :version => 1]]
},
:ways => {
# way created with nodes 1,2,3 (1 unclean) and node 4 later added by decliner
1 => [OSM::Way[[1,2,3], :id => 1, :changeset => 2, :version => 1],
OSM::Way[[1,2,3,4], :id => 1, :changeset => 3, :version => 2]]
})
bot = ChangeBot.new(db)
bot.process_all!
assert_equal([Edit[OSM::Way[[2,3], :id => 1, :changeset => -1, :version => 2]],
# Redact[OSM::Way, 1, 2, :hidden], # required in this test?
Delete[OSM::Node, 1]
],
bot.as_changeset)
end
##
# this tests removing two nodes from a way - one clean node that was added
# by a decliner, and one unclean node that was added by an agreer - leaving
# the way with only one node and thus subject to deletion.
def test_remove_two_nodes_from_way_for_different_reasons_resulting_in_one_node_way
db = DB.new(:changesets => {
1 => Changeset[User[true]],
2 => Changeset[User[true]],
3 => Changeset[User[false]]
},
:nodes => {
# we'll have to delete this
1 => [OSM::Node[[0,0], :id => 1, :changeset => 3, :version => 1]],
# but these ones are OK
2 => [OSM::Node[[1,1], :id => 2, :changeset => 1, :version => 1]],
3 => [OSM::Node[[1,1], :id => 3, :changeset => 1, :version => 1]]
},
:ways => {
# way created with nodes 1,2 (1 unclean) and node 3 later added by decliner
1 => [OSM::Way[[1,2], :id => 1, :changeset => 2, :version => 1],
OSM::Way[[1,2,3], :id => 1, :changeset => 3, :version => 2]]
})
bot = ChangeBot.new(db)
bot.process_all!
assert_equal([Delete[OSM::Way, 1],
# Redact[OSM::Way, 1, 2, :hidden], # required in this test?
Delete[OSM::Node, 1]
],
bot.as_changeset)
end
##
# this tests that a clean way does *not* have to be edited if a
# participating node has to be reverted to an earlier state but not
# deleted.
#
def test_way_remains
db = DB.new(:changesets => {
1 => Changeset[User[true]],
2 => Changeset[User[true]],
3 => Changeset[User[false]]
},
:nodes => {
# we'll have to revert this
1 => [OSM::Node[[0,0], :id => 1, :changeset => 1, :version => 1],
OSM::Node[[2,2], :id => 1, :changeset => 3, :version => 2]],
# these ones are OK
2 => [OSM::Node[[1,1], :id => 2, :changeset => 1, :version => 1]],
3 => [OSM::Node[[1,1], :id => 3, :changeset => 1, :version => 1]]
},
:ways => {
# Will not need editing
1 => [OSM::Way[[1,2,3], :id => 1, :changeset => 2, :version => 1]]
})
bot = ChangeBot.new(db)
bot.process_all!
assert_equal([Edit[OSM::Node[[0,0], :id => 1, :changeset => -1, :version => 2]],
# Redact[OSM::Node, 1, 2, :hidden] # is this needed???
],
bot.as_changeset)
end
##
# this tests that a clean relation may have to be edited,
# because an unclean node is deleted and cannot be
# referenced any more.
#
def test_remove_dirty_node_from_relation
db = DB.new(:changesets => {
1 => Changeset[User[true]],
2 => Changeset[User[true]],
3 => Changeset[User[false]]
},
:nodes => {
# we'll have to delete this
1 => [OSM::Node[[0,0], :id => 1, :changeset => 3, :version => 1]],
# but these ones are OK
2 => [OSM::Node[[1,1], :id => 2, :changeset => 1, :version => 1]],
3 => [OSM::Node[[1,1], :id => 3, :changeset => 1, :version => 1]]
},
:relations => {
# despite the clean-ness of this one it will have to be edited to
# get rid of the node which will be deleted because it's unclean.
1 => [OSM::Relation[[ [OSM::Node,1,"first"] , [OSM::Node,2,"second"] , [OSM::Node,3,"third"] ], :id => 1, :changeset => 2, :version => 1]]
})
bot = ChangeBot.new(db)
bot.process_all!
assert_equal([Edit[OSM::Relation[[ [OSM::Node,2,"second"] , [OSM::Node,3,"third"] ], :id => 1, :changeset => -1, :version => 1]],
Delete[OSM::Node, 1]
],
bot.as_changeset)
end
##
# this tests that a relation losing all its members will
# remain, and not be deleted like a way losing all its nodes.
#
def test_empty_relation_remains
db = DB.new(:changesets => {
1 => Changeset[User[true]],
2 => Changeset[User[true]],
3 => Changeset[User[false]]
},
:nodes => {
# we'll have to delete these
1 => [OSM::Node[[0,0], :id => 1, :changeset => 3, :version => 1]],
2 => [OSM::Node[[1,1], :id => 2, :changeset => 3, :version => 1]],
3 => [OSM::Node[[1,1], :id => 3, :changeset => 3, :version => 1]]
},
:relations => {
# will lose all members
1 => [OSM::Relation[[ [OSM::Node,1,"first"] , [OSM::Node,2,"second"] , [OSM::Node,3,"third"] ], :id => 1, :changeset => 2, :version => 1]]
})
bot = ChangeBot.new(db)
bot.process_all!
assert_equal([Edit[OSM::Relation[[ ], :id => 1, :changeset => -1, :version => 1]],
Delete[OSM::Node, 1],
Delete[OSM::Node, 2],
Delete[OSM::Node, 3]
],
bot.as_changeset)
end
##
# this tests that a clean relation may have to be edited,
# because an unclean way member is deleted and cannot be
# referenced any more.
#
def test_remove_dirty_way_from_relation
db = DB.new(:changesets => {
1 => Changeset[User[true]],
2 => Changeset[User[true]],
3 => Changeset[User[false]]
},
:nodes => {
# both ok
1 => [OSM::Node[[1,1], :id => 1, :changeset => 1, :version => 1]],
2 => [OSM::Node[[1,1], :id => 2, :changeset => 1, :version => 1]]
},
:ways => {
# not ok
1 => [OSM::Way[[1,2], :id => 1, :changeset => 3, :version => 1]]
},
:relations => {
# despite the clean-ness of this one it will have to be edited to
# get rid of the way.
1 => [OSM::Relation[[ [OSM::Node,1,"first"] , [OSM::Node,2,"second"] , [OSM::Way,1,"third"] ], :id => 1, :changeset => 2, :version => 1]]
})
bot = ChangeBot.new(db)
bot.process_all!
assert_equal([Edit[OSM::Relation[[ [OSM::Node,1,"first"] , [OSM::Node,2,"second"] ], :id => 1, :changeset => -1, :version => 1]],
Delete[OSM::Way, 1]
],
bot.as_changeset)
end
##
# this tests that a clean relation may have to be edited,
# because a clean way member has to be deleted due to consisting
# of too many unclean nodes, and the way now cannot be
# referenced by the relation any more.
#
def test_remove_dirty_node_from_way_and_way_from_relation
db = DB.new(:changesets => {
1 => Changeset[User[true]],
2 => Changeset[User[true]],
3 => Changeset[User[false]]
},
:nodes => {
# we'll have to delete this
1 => [OSM::Node[[0,0], :id => 1, :changeset => 3, :version => 1]],
# but this is OK
2 => [OSM::Node[[1,1], :id => 2, :changeset => 1, :version => 1]],
},
:ways => {
# loses a node, which makes it invalid and will have to be deleted even though clean
1 => [OSM::Way[[1,2], :id => 1, :changeset => 2, :version => 1]]
},
:relations => {
# loses one dirty node and the clean way, keeps the clean node
1 => [OSM::Relation[[ [OSM::Node,1,"first"] , [OSM::Node,2,"second"] , [OSM::Way,1,"third"] ], :id => 1, :changeset => 2, :version => 1]]
})
bot = ChangeBot.new(db)
bot.process_all!
assert_equal([Edit[OSM::Relation[[ [OSM::Node,2,"second"] ], :id => 1, :changeset => -1, :version => 1]],
Delete[OSM::Way, 1],
Delete[OSM::Node, 1]
],
bot.as_changeset)
end
end
if __FILE__ == $0
MiniTest::Unit.new.run(ARGV)
end