Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-conditional density estimators are initialized with context_features=None, should support 0 as well #1

Open
dgreenberg opened this issue Feb 10, 2020 · 2 comments · Fixed by sbi-dev/sbi#11
Open

Non-conditional density estimators are initialized with context_features=None, should support 0 as well #1

dgreenberg opened this issue Feb 10, 2020 · 2 comments · Fixed by sbi-dev/sbi#11

Comments

@dgreenberg
Copy link

the CDEs have a default input context_features which defaults to None. When this is a positive integer, we get a CDE, for a DE we need to set it to None. It should support a value of zero, though.
@janfb janfb transferred this issue from another repository Feb 11, 2020
@jan-matthis jan-matthis reopened this Feb 11, 2020
@alvorithm
Copy link

alvorithm commented Mar 5, 2020 •
edited
Loading

Example at mackelab/nflows:

nflows/nflows/transforms/autoregressive.py

Line 68 in 78b5796

context_features=None,

As far as I can tell, this issue now belongs in mackelab/nflows, then upstreamed. What do you think, @dgreenberg?

@alvorithm alvorithm changed the title non-conditional density estimators are initialized with context_features=None, should support 0 as well Non-conditional density estimators are initialized with context_features=None, should support 0 as well Mar 5, 2020
@alvorithm alvorithm transferred this issue from sbi-dev/sbi Mar 5, 2020
@dgreenberg
Copy link
Author

Example at mackelab/nflows:

nflows/nflows/transforms/autoregressive.py

Line 68 in 78b5796

context_features=None,

As far as I can tell, this issue now belongs in mackelab/nflows, then upstreamed. What do you think, @dgreenberg?

Agreed

@alvorithm alvorithm transferred this issue from mackelab/nflows-nofork Mar 24, 2020
alvorithm pushed a commit that referenced this issue Apr 6, 2020
@arturbekasov
Merge pull request #1 from mackelab/tensor-construction-warnings
6d4f5dd 
Tensor construction warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install deps sbi-dev/sbi
3 participants
@dgreenberg @alvorithm @jan-matthis