TF1 Interpolation is back #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature_SuperTF1
… loading from ROOT file... arghhh
…o feature_SuperTF1
…w to obtain better step time as all neccesary ifnrimation are in one pointer resutling in better cache performance
…o feature_SuperTF1
KSkwarczynski
added
Performance
…o feature_SuperTF1
github-actions
bot
added
the
Documentation
github-actions
bot
removed
the
Documentation
github-actions
bot
added
Nu Osc/Xsec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description:
Clarence implemented TF1 interpolation long time ago. It was meant to be low RAM compared with TSpline3. Howeer as discussed here https://github.com/t2k-software/MaCh3/issues/456 it doesn't always work also you could use either TSpline 3 or TF1
This PR is meant to allow to use TSpline3 and TF1 AT THE SAME TIME. It didn't fix aformentioned problems. Thus right now only TF1 allowed linear interpolation.
For CI test merge this: mach3-software/MaCh3Tutorial#4
Changes or fixes:
Examples:
Test were done using low stat on low number of dials. In full production impact will be much higher.
LLH:
LLHScan_linear_vs_tf1.pdf
RS_delta is much different becasue I forgot it has more than 2 knots...
also CPU vs GPU
LLHScan_CPU_GPU.pdf
Speed:
TSpline3 vs TF1
StepTimeComparison.pdf
+Struct holding spline mono info
StepTimeComparison.pdf
RAM:
Only TSpline3
TSpline3 + TF1
That's like 30% RAM decrase