Feature flexible binning #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… y_var accordingly. Also made x_var, y_var const pointers so they can't be altered in the core code, they can still be altered in the daughter class
…m the sample config or elsewhere
…y the splines directly along with the strings associated with each variable that the spline is binned in. This always is assumed to mean that your spline are binned in true neutrino energy plus your sample binning
…so removing the hard-coded *0.001 to the xvar which was baked in there due to a GeV vs MeV problem.
… splines also change in print out
… only binning in one variable
…sample binning. Can now have different binning for sample and spline but still has to be in the same variables
…indexing is simplified
…access beyond xArray size of spline knots when nKnots was 2. I also made the FindSplineSegment near identical to how it is done for the ND in the SplineMonolithClass
…e of nPars is one extra if statement we don't need in the reweighting
…is means we no longer need to pass oscillation parameters to the reweight call. Instead we just have an array of pointers to the proposed oscillation parameter, a lot more like the covarianceXsec parameters
…this was just not a problem with previous versions of ROOT?
…the global index, this is needed for accessing vectors which can be of size _fNumPar of _fNumSplines
…d calc to be consistent
…ex, this has tripped me up several times
…icated function defintions in covarianceXsec.h and remove pot from samplePDFBase init functions
KSkwarczynski
approved these changes
Aug 23, 2024
… return relative spline index.
…aCh3 into feature_FlexibleBinning
…anceXsec object but this can have zero splines in now
…aCh3 into feature_FlexibleBinning Getting the YAML root converter stuff that Kamil committed
…ftware/MaCh3 into feature_FlexibleBinning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description:
Various changes on the FD side to make the setup slightly more flexible and some smaller changes. No more binning opt to set the the number of dimensions you want your sample to be binned in. Also a change so that you don't have to pass oscillation parameters (or a null array) to the reweight function.
Changes or fixes:
No more binning opt.
Fix to spline evaluation and now use maps to get the systematic and spline indices for particular DetIds
Examples:
NA