Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tkinter might not be shipped with python #159

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

ccccclw
Copy link
Contributor

@ccccclw ccccclw commented Oct 25, 2023

This PR handles tkinter import error when it's not shipped with python installed on certain OS. In fact, I am not sure if we need this module or not here .

@jlmaccal
Copy link
Contributor

I'm super confused here...

  1. Why do we need tkinter in the guts of MELD?
  2. Why are we importing E? It's not even used.

@ccccclw
Copy link
Contributor Author

ccccclw commented Oct 25, 2023

well..that's what I got confused too. Looks like it was somehow added around this point. I just removed the import.

@ccccclw
Copy link
Contributor Author

ccccclw commented Nov 7, 2023

Add another commit for resolving bugs in extract_trajectory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants