Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal doesn't resize in some cases #31

Closed
grassick opened this issue Aug 12, 2016 · 3 comments
Closed

Modal doesn't resize in some cases #31

grassick opened this issue Aug 12, 2016 · 3 comments
Assignees
Labels

Comments

@grassick
Copy link
Member

image

Go to portal.mwater.co/#datagrids

Pick Water Point, flip to filter tab. Then click on the box. It puts a scroll bar instead of making the modal bigger.

@broncha
Copy link
Contributor

broncha commented Aug 15, 2016

@grassick I just hit this too while working on expressions for ImageWidgetComponent.
This one is really tricky as the dropdown is absolutely positioned. I tested with bootstrap collapse and it stretches the modal body as expected.

Working on a fix for absolutely positioned elements.

@broncha
Copy link
Contributor

broncha commented Aug 15, 2016

The fix for scrolling modal body is a blocker to fix this one. We added overflow: auto to modal body which makes the dropdown to actually scroll. If we remove overflow:auto the dropdown will pop out of the modal.

@broncha
Copy link
Contributor

broncha commented Aug 25, 2016

After 29dd8d6. it looks like this
screen shot 2016-08-25 at 4 03 59 pm

@broncha broncha closed this as completed Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants