Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated React context #461

Open
grassick opened this issue Sep 17, 2021 · 0 comments
Open

Remove deprecated React context #461

grassick opened this issue Sep 17, 2021 · 0 comments
Assignees

Comments

@grassick
Copy link
Member

grassick commented Sep 17, 2021

React contexts are newly designed https://reactjs.org/docs/context.html and the old method is deprecated and removed in future React.

There are several types of context:

  1. locale
  2. table selection (mwater-expressions-ui)
  3. add map layer (mwater-visualization)
  4. global filter (mwater-visualization)
  5. scalar expression tree decoration (3 functions) (mwater-expressions-ui)

Locale should probably just be a prop passed down everywhere.

Rest should be 4 separate contexts

@grassick grassick self-assigned this Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant