Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default colours for pie chart #454

Open
Autio opened this issue Jun 29, 2021 · 4 comments
Open

Default colours for pie chart #454

Autio opened this issue Jun 29, 2021 · 4 comments
Assignees

Comments

@Autio
Copy link
Contributor

Autio commented Jun 29, 2021

WaterAid suggested pie charts could default their first option to a green colour since most often they use pie charts for visualizing proportions of yes/no questions and most often yes is a good thing. Annie suggests we make the fix ourselves, but that we make the series' colour neutral to begin with, so that users don't end up with a stark red default for the option that should be green etc.

@Autio Autio changed the title Default pie chart first option to green Default colours for pie chart Jun 29, 2021
@grassick
Copy link
Member

How do we want the colors to change? Here are the current ones... we can rearrange them as necessary:

image

Red and green are 3 and 4, and I'm worried about the default being ugly if we move them down. i.e. colors 5-8 are ugly.

Here are some alternate palettes:

https://nanx.me/ggsci/reference/pal_d3.html

https://carto.com/carto-colors/ (see categorical section)

@grassick
Copy link
Member

grassick commented Aug 4, 2021

Maybe switch to paired default? Check if affects existing charts. Make darker pair item first. https://github.com/d3/d3-scale-chromatic#schemePaired

@grassick
Copy link
Member

grassick commented Aug 4, 2021

Do not modify existing charts! Maybe have an easier picker for color scheme changes.

@grassick
Copy link
Member

grassick commented Aug 4, 2021

Initial tests show that colors appear to be stable, but needs more testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants