Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all parameters applying when exporting as PDF #241

Open
1 of 2 tasks
Autio opened this issue Apr 1, 2021 · 4 comments
Open
1 of 2 tasks

Not all parameters applying when exporting as PDF #241

Autio opened this issue Apr 1, 2021 · 4 comments
Assignees

Comments

@Autio
Copy link
Contributor

Autio commented Apr 1, 2021

  • Pivot table cell background colours are not exported to PDF
  • Dashboard map layers all get exported to PDF even when some layers are not active

Examples here:
https://share.mwater.co/v3/dashboard_link/8825f8017d1f472bbcf9203631d09b5d?share=e9f165a349b64c978e269767b563a864

I also notice PDF export generation can take a fairly long time.

Side note on pivot table cell backgrounds: Is there any simple way to switch the value in a cell that has a very dark background to be white or at least bright instead? Now black text gets lost in dark blue for example.

@broncha
Copy link
Contributor

broncha commented Apr 6, 2021

I have a fix for the text color, where it switches between white and black text for dark and light background colors resp.
But the layers thing is a bit more involved.

Basically, the layer toggling is client-side and scoped to the particular map widget and the server is unaware of it.
The example contains one map widget, but a dashboard can contain multiple maps, so what we will need to do is to pass all visible layers of all the maps in the dashboard to the server, which will toggle the respective layers while generating PDF.

That is, keep a record of all the visible layers in top-level in dashboard, and pass that to the server for PDF generation

@grassick
Copy link
Member

grassick commented Apr 6, 2021

That's going to add quite a bit more complexity to pull the layer selection up to the top level, no? Let's talk about this one more before executing it.

@broncha
Copy link
Contributor

broncha commented Apr 7, 2021

@broncha
Copy link
Contributor

broncha commented Apr 7, 2021

color contrast in pivot table cells also done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants