-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require <input>
; Find all supported files in cwd automatically
#410
Comments
Basic support for this will be merged together with #330. It provides directory support and will check
|
The question is if we also want to test the current directory when omitting the
would be the same as
I can see good arguments for both. Opinions? |
I thought about it and decided not to test the current directory when omitting the |
With #330 being merged, |
Including all the supported extensions by default makes more sense to me, with the possibility to override the list with the flag if someone wants fewer extensions. This is because
|
Lychee can extract links from plaintext documents, so technically it could work with files like YAML or XML as well. Even files without an extension might be fine (e.g. |
@mre |
Yeah, doing what ripgrep does sounds like a sane default. In the end, lychee is like a tiny ripgrep with a different objective. 😉 On the other hand I'm not sure if people would be interested in broken links inside SVG and XLS files. If you have a link to the algorithm I'd love to have a look. |
@mre |
To summarize:
|
### What Code files are now included in link checking. * Fixes #5925 Some issues encountered: * globs don't respect exclude_files which makes working with this locally harder lycheeverse/lychee#1405 * can't specify extensions / correct files aren't picked up automatically lycheeverse/lychee#410 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5986?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5986?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5986) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
This adds support for overwriting extensions: ``` lychee . --extensions md,html,txt,json,yaml ``` The above would only check these extensions. This was enabled by moving to `ignore` (#1500 by @thomas-zahner). Fixes #410
Lychee supports a lot of files, I'd rather not have to maintain my own glob list. Can it just find and check all the supported filetypes like Prettier does for example?
The text was updated successfully, but these errors were encountered: