From 6422b85407d1a65d03d82815bae90385e1bceeea Mon Sep 17 00:00:00 2001 From: loreabad6 Date: Tue, 9 Apr 2024 14:30:14 +0200 Subject: [PATCH] release: Update cran comments :bookmar: --- cran-comments.md | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 802667c8..e123dc7a 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,27 +1,18 @@ In this release we have made the following changes: -* Argument names of sfnetwork S3 methods for `sf::st_geometry()`, `sf::st_bbox()`, `sf::st_m_range()` and `sf::st_set_precision()` are updated to be consistent with their corresponding generic functions in sf. -* Arguments `active` and `...` are removed from the sfnetwork S3 method for `sf::st_precision()` to be consistent with its corresponding generic function in sf. -* Argument `active` is removed from the sfnetwork S3 method for `sf::st_crs()` to be consistent with the above-mentioned change regarding `sf::st_precision()` (since both CRS and precision can not differ between nodes and edges). +* To address CRAN error on Fedora, the package version is now specified as a character instead of numeric. -These changes solve the warnings in the CRAN checks regarding S3 method consistency. +* The `sfnetwork()` construction function now has an argument `message` which can be set to `FALSE` when the network validity checks should not print informational messages to the console. Refs [#261](https://github.com/luukvdmeer/sfnetworks/issues/261). + +* Code and documentation was updated where needed to align with changes in base R and/or package dependencies. No changes to program logic or behavior. ## R CMD check results 0 errors | 0 warnings | 0 notes -When running checks on R-hub, the following note occured only on Windows (Server 2022, R-devel 64-bit): - -``` -* checking for detritus in the temp directory ... NOTE -Found the following files/directories: - 'lastMiKTeXException' -``` -As noted in [R-hub issue #503](https://github.com/r-hub/rhub/issues/503), this is a bug in R-hub rather than a bug in our package, and can likely be ignored. - ## revdepcheck results -We checked 1 reverse dependencies (0 from CRAN + 1 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package. +We checked 3 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. * We saw 0 new problems * We failed to check 0 packages