Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Browser runner in favor of Web runner #4

Open
tannisroot opened this issue Mar 9, 2019 · 8 comments
Open

Deprecate Browser runner in favor of Web runner #4

tannisroot opened this issue Mar 9, 2019 · 8 comments
Assignees

Comments

@tannisroot
Copy link
Collaborator

Web runner is far more advanced, works way better and can do the same things Browser runner can.
So why does the latter still exist and even comes pre-installed with default Lutris configuration and no option to remove it?

@aboogesnickle
Copy link

Currently I am unable to use web runner for Duelyst because it does not support WebGL. I am using the Browser Runner with my default browser right now to play it.

Some one comment on this saying that the Electron Browser that Web Runner uses needs to be updated, but I would like to use the Browser Runner until that is fixed.

@tannisroot
Copy link
Collaborator Author

Web runner does support WebGL. Can't test the game though as it's region locked.

@strycore
Copy link
Member

strycore commented Jan 1, 2020

I can reproduce this issue. I'm moving it in the buildbot web-runner repo since this requires a runner update.

Screenshot from 2020-01-01 14-44-58

@strycore strycore transferred this issue from lutris/lutris Jan 1, 2020
@strycore
Copy link
Member

strycore commented Jan 1, 2020

@daniel-j that might be an option to pass at build time?

@tannisroot
Copy link
Collaborator Author

Various test pages show that our Web runner does actually support WebGL:
image
Perhaps this is some user agent crap?

@rejexy
Copy link

rejexy commented Feb 21, 2020

Screenshot from 2020-02-21 16-10-32
I have same problem with webGL

@rejexy
Copy link

rejexy commented Feb 21, 2020

I found solution. Usage electron from distro repo supports webGL.

@Medath
Copy link
Contributor

Medath commented May 5, 2020

I'm pretty sure just upgrading the electron version in the web runner will help. At least my testing from quite a while ago suggests that. The current web runner uses an electron version that's over two and a half years old by now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants