add smoke test and remove play json from the dependencies #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should not be necessary since it's pulled by the play framework
AurelienRichez
force-pushed
the
fix/add-smoke-test
branch
3 times, most recently
from
8a57acf to
8878322
Compare
AurelienRichez
force-pushed
the
fix/add-smoke-test
branch
from
8878322 to
8a99753
Compare
wjglerum
reviewed
Oct 4, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
pepite
pushed a commit
that referenced
this pull request
Sep 2, 2024
* remove play json from the dependencies It should not be necessary since it's pulled by the play framework * Add a smoke test for the application * add smoke test in scalatest instead of bash script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the play json dependency because it's not needed.
As a bonus, since the previous version change crashed the app. I added a small script that :
sbt stageto get a binary that is as close as possible to production and thenThis can protect us from that problem in the future