Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Enhancement Proposal: Support for Custom Partition Keys and DynamoDBAsyncClient in Shedlock #2076

Open
himanshu8434 opened this issue Aug 9, 2024 · 2 comments

Comments

@himanshu8434
Copy link

Hello @lukas-krecan

Our team is looking to use Shedlock for task scheduling in our project, and we plan to use DynamoDB as our database. We have identified a few areas where the Shedlock DynamoDB provider could be improved:

  1. Custom Partition Key Name: Currently, the partition key name in the DynamoDB provider is static and set to _id. This limitation poses a challenge for us as we have existing tables in production where the partition key is named differently. It would be helpful if the partition key name could be passed as a parameter when initializing the DynamoDB provider. This flexibility would allow us to utilize our existing tables without having to modify them.

  2. Support for DynamoDBAsyncClient: In our Spring WebFlux project, we use non-blocking code extensively and have a DynamoDbAsyncClient bean for interacting with DynamoDB. However, Shedlock does not currently support the DynamoDbAsyncClient, necessitating the creation of an additional DynamoDB client bean specifically for Shedlock. It would be beneficial if the DynamoDB provider could be updated to support both DynamoDbClient and DynamoDbAsyncClient, enabling us to maintain a fully non-blocking architecture.

if you need any support or assistance in implementing these features, I would be happy to contribute to the development effort.

Thanks!

@lukas-krecan
Copy link
Owner

Hi, thanks. Please send a PR for both issues.

@kumar-himans
Copy link
Contributor

Hi @lukas-krecan, Sorry for the delayed response, I have raised the PR for the 1st issue. Please check #2121 . This is my corporate GitHub account.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants