Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added droplet-off icon #2641

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Nov 26, 2024

What is the purpose of this pull request?

  • New Icon

Description

Added new droplet-off icon.

Icon use case

See #2632

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @colebemis
  • I've based them on the following Lucide icons: droplet
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Nov 26, 2024
Copy link

github-actions bot commented Nov 26, 2024

Added or changed icons

icons/droplet-off.svg

Preview cohesion icons/square-arrow-out-down-left.svg
icons/droplet-off.svg
icons/map-pin-check-inside.svg
Preview stroke widths icons/droplet-off.svg
icons/droplet-off.svg
icons/droplet-off.svg
DPI Preview (24px) icons/droplet-off.svg
Icon X-rays icons/droplet-off.svg
Icon Diffs icons/droplet-off.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const DropletOffIcon = createLucideIcon('DropletOff', [
  ["path",{"d":"M18.715 13.186C18.29 11.858 17.384 10.607 16 9.5c-2-1.6-3.5-4-4-6.5a10.7 10.7 0 0 1-.884 2.586"}],
  ["path",{"d":"m2 2 20 20"}],
  ["path",{"d":"M8.795 8.797A11 11 0 0 1 8 9.5C6 11.1 5 13 5 15a7 7 0 0 0 13.222 3.208"}]
])

Copy link

Added or changed icons

icons/droplet-off.svg

Preview cohesion icons/square-stack.svg
icons/droplet-off.svg
icons/wifi-zero.svg
Preview stroke widths icons/droplet-off.svg
icons/droplet-off.svg
icons/droplet-off.svg
DPI Preview (24px) icons/droplet-off.svg
Icon X-rays icons/droplet-off.svg
Icon Diffs icons/droplet-off.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const DropletOffIcon = createLucideIcon('DropletOff', [
  ["path",{"d":"M18.715 13.186C18.29 11.858 17.384 10.607 16 9.5c-2-1.6-3.5-4-4-6.5a10.7 10.7 0 0 1-.884 2.586"}],
  ["path",{"d":"m2 2 20 20"}],
  ["path",{"d":"M8.795 8.797A11 11 0 0 1 8 9.5C6 11.1 5 13 5 15a7 7 0 0 0 13.222 3.208"}]
])

@karsa-mistmere
Copy link
Member

How does this relate to #2632 ?

@jguddas
Copy link
Member Author

jguddas commented Nov 26, 2024

#2632

It's the automatically generated version that @Footagesus tried to painstakingly handcraft.
The upside of having this automated version is that there are no accidental errors introduced, rounding errors, missing contributors, etc.

@Footagesus
Copy link

Okay, I don't mind. The important thing is that the icon was added.

icons/droplet-off.json Outdated Show resolved Hide resolved
icons/droplet-off.json Outdated Show resolved Hide resolved
@Footagesus
Copy link

Yo ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants