From 1a22e32024f8a123f2e8654f3f2cc9f44fde2ea2 Mon Sep 17 00:00:00 2001 From: Marco 'Lubber' Wienkoop Date: Fri, 25 Oct 2024 21:01:48 +0200 Subject: [PATCH] fix(ci): dont let job fail for latest node Latest node 23 ci check fails because of active development and dependencies would need an update or fix However, even if this check is declared as not required, the github actions still fail, which is a false positive as long as it's not an LTS version (which node 23 isn't) To get rid of the failures, this PR removes the latest node check and adds dedicated LTS version instead which makes the CI succeed again. Will review this for latest node again when working on 2.10.x soon --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 97e7b45a0d..abcbc6be84 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -26,7 +26,7 @@ jobs: strategy: fail-fast: false matrix: - node-version: [12, 14, 16, 18, latest] + node-version: [12, 14, 16, 18, 20, 22] steps: - uses: actions/checkout@v4 - name: Setup Node.js ${{ matrix.node-version }}