Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customizable to_parquet arguments (e.g., geometry_encoding) #59

Open
martibosch opened this issue Aug 27, 2024 · 0 comments
Open

customizable to_parquet arguments (e.g., geometry_encoding) #59

martibosch opened this issue Aug 27, 2024 · 0 comments

Comments

@martibosch
Copy link
Collaborator

          If I understood correctly, this is automatically done if a non-None `geometry` is provided after #58, right @sphamba ?

Basically if df_attrs is a GeoDataFrame, we are thus using GeoDataFrame.to_parquet, that already takes care of writing the geometry columns. Should we use "geoarrow" instead of the default "WKB" (see the geometry_encoding argument at https://geopandas.org/en/stable/docs/reference/api/geopandas.GeoDataFrame.to_parquet.html)?

In any case, I doubt this is any performance bottleneck for most use cases and I would like to avoid any premature optimization, but I can (i) test the effects with a proper benchmark and (ii) add a to_parquet_kwargs argument to the to_tstore methods which is forwarded to df_attrs.to_parquet.

Originally posted by @martibosch in #19 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant