Fixed bug override globally configured pageSize variable in the middle of the code #299
Conversation
coudot
changed the title
There was a problem hiding this comment.
Hello Abishek,
Check out doGetAttrsList method, we seem to have lost paginated load of pivots (only first paged loaded ?) and some control are not passed on anymore.
To reproduce issue, one should have a LDAP directory with many users ( + 2000), a pageSize at 500, and an olcLimits should apply for the account that connect to source.
There when searching for over olcLimits in a dataset (for members for example), you should see less entry returns than expected (as they are limited by olcLimits), while one should expect a paginated load of theses entries so that olcLimits is not reach and no entry is missed.
abpai94
force-pushed
the
176-bug-dn-elements-max-pagesize
branch
from
847c512
to
64e3dac
Compare
|
@davidcoutadeur I have understood the problem better and proposed a new fix. The commits have been squashed as requested. |
- Clearing requestControlContext in finally block
abpai94
force-pushed
the
176-bug-dn-elements-max-pagesize
branch
from
3308b20
to
74c3ca6
Compare
|
@davidcoutadeur I have applied fixes corresponding to your comments. This is ready to merge. |
#176