Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to README.md regarding baremetal.patch #63

Open
colematt opened this issue Aug 2, 2018 · 1 comment
Open

Updates to README.md regarding baremetal.patch #63

colematt opened this issue Aug 2, 2018 · 1 comment

Comments

@colematt
Copy link

colematt commented Aug 2, 2018

Based on the status of patch D46822 -- which appears to be accepted, closed, and committed to upstream as of July 31, 2018 -- is this step under How can I build upstream LLVM+Clang... still required?

wget https://reviews.llvm.org/D46822?download=true -O baremetal.patch
patch -p0 < baremetal.patch

When I attempted to apply the patch, I got the dreaded "Reversed (or previously applied) patch detected!" error from patch. It seems the patch's contents are now all in the upstream source.

@liang1232018
Copy link

I have read the upstream source code git from https://github.com/riscv/riscv-gnu-toolchain .
ALL the patch in baremetal.patch has already been added in the source code.
so , I think it's not required now, And I build the llvm-upstream without that patch successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants