Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[capture] Re-add range / saturation checks for Husky #276

Open
vogelpi opened this issue Jan 9, 2024 · 2 comments
Open

[capture] Re-add range / saturation checks for Husky #276

vogelpi opened this issue Jan 9, 2024 · 2 comments
Labels
enhancement New feature or request Priority:P2

Comments

@vogelpi
Copy link
Collaborator

vogelpi commented Jan 9, 2024

When doing FPGA measurements, I noticed that - at least for AES - we no longer have range / saturation checks for Husky. If the user chooses a gain value which is to high, the ADC will just saturate which invalidates measurements. It's pretty difficult to detect such issues without these automated checks. I am strongly in favor for re-adding them again.

@vogelpi vogelpi added enhancement New feature or request Priority:P1 labels Jan 9, 2024
@johannheyszl
Copy link
Collaborator

Thanks, beg to differ pls:

  • We have the plots after capture which are super helpful to assess whether capture was meaningful. I think users should always run with low amount of traces, check the plot for sanity and then start longer captures.
  • In many cases, there are spikes from e.g. GPIO trigger toggles that would be misleading.
  • I think it is extremely important to point all users to inspecting plots instead of console output only. One danger from simple going from console output is that users use low gains and reduce signal just because of spikes that are not relevant.

@vogelpi
Copy link
Collaborator Author

vogelpi commented Jan 11, 2024

Thanks for your feedback @johannheyszl . This makes a lot of sense, especially now when we thing about the real chip when more things will go on in the background. I agree that people should always carefully inspect the waves first. Let's at least de-prioritize this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority:P2
Projects
None yet
Development

No branches or pull requests

2 participants