[rom, rom_ext] Re-arrange retention RAM #21343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesdai
approved these changes
Feb 13, 2024
sameo
approved these changes
Feb 14, 2024
pamaury
reviewed
Feb 14, 2024
| * - We can resize boot_svc without affecting the upper half of the struct. | ||
| * The remaining space is reserved for future use. | ||
| * | ||
| * We Are locating the boot_svc at the beginning and the rest of the members |
pamaury
approved these changes
Feb 14, 2024
timothytrippel
approved these changes
Feb 20, 2024
cfrantz
force-pushed
the
retention_ram
branch
2 times, most recently
from
2828c74 to
09fe164
Compare
Re-arrange the retention RAM as discussed in the SW WG meeting on 2024-02-13: Locate the boot_svc message first, followed by reserved space, followed by the boot_log and last_shutdown_reason. This arrangement allows us to grow the boot_svc message (growing "down" into the reserved space) if needed and to add additional fields at the end (growing "up" into the reserved space). Also: name the ASCII code for boot log as `BLOG` instead of `BOLG`. Signed-off-by: Chris Frantz <[email protected]>
cfrantz
force-pushed
the
retention_ram
branch
from
09fe164 to
30a3344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-arrange the retention RAM as discussed in the SW WG meeting on 2024-02-13:
Locate the boot_svc message first, followed by reserved space, followed by the boot_log and last_shutdown_reason. This arrangement allows us to grow the boot_svc message (growing "down" into the reserved space) if needed and to add additional fields at the end (growing "up" into the reserved space).