From 6d224e7c5d8b6a7cdcaa71fc65d68c526faf1b15 Mon Sep 17 00:00:00 2001 From: Shahid Mehmood Date: Thu, 28 Dec 2023 12:12:21 +0500 Subject: [PATCH] [RV_DM] rv_dm_sba_debug_disabled_vseq The test ensures that the SBA interface is disabled when 'lc_hw_debug_en' is not set to true, ensuring no SBA TL accesses occur. Signed-off-by: Shahid Mehmood --- hw/ip/rv_dm/data/rv_dm_testplan.hjson | 2 +- hw/ip/rv_dm/dv/env/rv_dm_env.core | 1 + hw/ip/rv_dm/dv/env/rv_dm_scoreboard.sv | 10 ++++-- .../seq_lib/rv_dm_sba_debug_disabled_vseq.sv | 32 +++++++++++++++++++ hw/ip/rv_dm/dv/env/seq_lib/rv_dm_vseq_list.sv | 1 + hw/ip/rv_dm/dv/rv_dm_sim_cfg.hjson | 5 +++ 6 files changed, 48 insertions(+), 3 deletions(-) create mode 100644 hw/ip/rv_dm/dv/env/seq_lib/rv_dm_sba_debug_disabled_vseq.sv diff --git a/hw/ip/rv_dm/data/rv_dm_testplan.hjson b/hw/ip/rv_dm/data/rv_dm_testplan.hjson index d054d680e16360..f95a06c4366c8d 100644 --- a/hw/ip/rv_dm/data/rv_dm_testplan.hjson +++ b/hw/ip/rv_dm/data/rv_dm_testplan.hjson @@ -294,7 +294,7 @@ - Verify via assertion checks, no transactions were seen on the SBA TL interface. ''' stage: V2 - tests: [] // TODO(#15668) + tests: ["rv_dm_sba_debug_disabled"] } { name: ndmreset_req diff --git a/hw/ip/rv_dm/dv/env/rv_dm_env.core b/hw/ip/rv_dm/dv/env/rv_dm_env.core index f86e07d382692a..1c05e2b76d764a 100644 --- a/hw/ip/rv_dm/dv/env/rv_dm_env.core +++ b/hw/ip/rv_dm/dv/env/rv_dm_env.core @@ -45,6 +45,7 @@ filesets: - seq_lib/rv_dm_jtag_dmi_dm_inactive_vseq.sv: {is_include_file: true} - seq_lib/rv_dm_jtag_dmi_debug_disabled_vseq.sv: {is_include_file: true} - seq_lib/rv_dm_jtag_dtm_hard_reset_vseq.sv: {is_include_file: true} + - seq_lib/rv_dm_sba_debug_disabled_vseq.sv: {is_include_file: true} file_type: systemVerilogSource generate: diff --git a/hw/ip/rv_dm/dv/env/rv_dm_scoreboard.sv b/hw/ip/rv_dm/dv/env/rv_dm_scoreboard.sv index 7a8f79911c113f..7978e330ff6b1e 100644 --- a/hw/ip/rv_dm/dv/env/rv_dm_scoreboard.sv +++ b/hw/ip/rv_dm/dv/env/rv_dm_scoreboard.sv @@ -186,10 +186,16 @@ class rv_dm_scoreboard extends cip_base_scoreboard #( item.sprint(uvm_default_line_printer)), UVM_HIGH) if (sba_tl_access_q.size() > 0) begin compare_sba_access(item, sba_tl_access_q.pop_front()); - end else begin + end + else if (cfg.rv_dm_vif.lc_hw_debug_en==lc_ctrl_pkg::Off) begin + `uvm_info(`gfn, $sformatf("Does not receive SBA access item:\n%0s", + item.sprint(uvm_default_line_printer)), UVM_HIGH) + end + else begin `uvm_error(`gfn, $sformatf({"Received predicted SBA access but no transaction was seen on ", - "the SBA TL host interface: %0s"}, + "the SBA TL host interface: %0s"}, item.sprint(uvm_default_line_printer))) + end end endtask diff --git a/hw/ip/rv_dm/dv/env/seq_lib/rv_dm_sba_debug_disabled_vseq.sv b/hw/ip/rv_dm/dv/env/seq_lib/rv_dm_sba_debug_disabled_vseq.sv new file mode 100644 index 00000000000000..1a3a28ec83b79a --- /dev/null +++ b/hw/ip/rv_dm/dv/env/seq_lib/rv_dm_sba_debug_disabled_vseq.sv @@ -0,0 +1,32 @@ +// Copyright lowRISC contributors. +// Licensed under the Apache License, Version 2.0, see LICENSE for details. +// SPDX-License-Identifier: Apache-2.0 + +class rv_dm_sba_debug_disabled_vseq extends rv_dm_sba_tl_access_vseq; + `uvm_object_utils(rv_dm_sba_debug_disabled_vseq) + + `uvm_object_new + + constraint lc_hw_debug_en_c { + lc_hw_debug_en == lc_ctrl_pkg::On; + } + constraint scanmode_c { + scanmode == prim_mubi_pkg::MuBi4False; + } + + task body(); + repeat ($urandom_range(1, 10)) begin + csr_wr(.ptr(jtag_dmi_ral.dmcontrol.dmactive), .value(1)); + req = sba_access_item::type_id::create("req"); + randomize_req(req); + cfg.debugger.sba_access(req); + cfg.clk_rst_vif.wait_clks($urandom_range(0, 1000)); + cfg.rv_dm_vif.lc_hw_debug_en<=lc_ctrl_pkg::Off; + csr_wr(.ptr(jtag_dmi_ral.dmcontrol.dmactive), .value(1)); + req = sba_access_item::type_id::create("req"); + randomize_req(req); + cfg.debugger.sba_access(req); + `DV_CHECK_EQ(req.is_err, SbaErrNone) + end + endtask : body +endclass : rv_dm_sba_debug_disabled_vseq diff --git a/hw/ip/rv_dm/dv/env/seq_lib/rv_dm_vseq_list.sv b/hw/ip/rv_dm/dv/env/seq_lib/rv_dm_vseq_list.sv index 4f51c22d2b0cda..cdeef5df1ae019 100644 --- a/hw/ip/rv_dm/dv/env/seq_lib/rv_dm_vseq_list.sv +++ b/hw/ip/rv_dm/dv/env/seq_lib/rv_dm_vseq_list.sv @@ -23,3 +23,4 @@ `include "rv_dm_jtag_dmi_dm_inactive_vseq.sv" `include "rv_dm_jtag_dmi_debug_disabled_vseq.sv" `include "rv_dm_jtag_dtm_hard_reset_vseq.sv" +`include "rv_dm_sba_debug_disabled_vseq.sv" diff --git a/hw/ip/rv_dm/dv/rv_dm_sim_cfg.hjson b/hw/ip/rv_dm/dv/rv_dm_sim_cfg.hjson index 9fe2290a3ca0f0..349dcf862a95dd 100644 --- a/hw/ip/rv_dm/dv/rv_dm_sim_cfg.hjson +++ b/hw/ip/rv_dm/dv/rv_dm_sim_cfg.hjson @@ -250,6 +250,11 @@ uvm_test_seq: rrv_dm_jtag_dtm_hard_reset_vseq reseed: 2 } + { + name: rv_dm_sba_debug_disabled + uvm_test_seq: rv_dm_sba_debug_disabled_vseq + reseed: 2 + } ] // List of regressions.