Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[rtl] Fix counter reset value on FPGA" #2229

Merged
merged 1 commit into from
Dec 4, 2024

Revert "[rtl] Fix counter reset value on FPGA"

b30abd4
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Revert "[rtl] Fix counter reset value on FPGA" #2229

Revert "[rtl] Fix counter reset value on FPGA"
b30abd4
Select commit
Loading
Failed to load commit list.
GitHub Actions / verible-verilog-lint succeeded Dec 2, 2024 in 0s

reviewdog [verible-verilog-lint] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (103)

formal/icache/formal_tb.sv|218 col 101| Line length exceeds max: 100; is: 104 [Style: line-length] [line-length]
dv/uvm/core_ibex/tests/core_ibex_vseq.sv|75 col 70| The 'name' argument of type_id::create() must match the name of the variable to which it is assigned: irq_raise_single_seq_h, got: "irq_single_seq_h". [Style: uvm-naming] [create-object-name-match]
dv/uvm/icache/dv/ibex_icache_mem_agent/ibex_icache_mem_resp_item.sv|29 col 14| Constraint names must obey the following regex: ([a-z0-9]+)+c [Style: constraints] [constraint-name-style]
dv/uvm/icache/dv/ibex_icache_mem_agent/ibex_icache_mem_resp_item.sv|39 col 14| Constraint names must obey the following regex: ([a-z0-9]+
)+c [Style: constraints] [constraint-name-style]
vendor/lowrisc_ip/dv/sv/dv_base_reg/csr_excl_item.sv|15 col 5| Struct names have to end with t [Style: struct-union-conventions] [struct-union-name-style]
vendor/lowrisc_ip/ip/prim/pre_dv/prim_sync_reqack/rtl/prim_sync_reqack_tb.sv|30 col 101| Line length exceeds max: 100; is: 115 [Style: line-length] [line-length]
vendor/lowrisc_ip/ip/prim/pre_dv/prim_sync_reqack/rtl/prim_sync_reqack_tb.sv|111 col 13| $random is a forbidden system function or task, please use $urandom instead [Style: forbidden-system-functions] [invalid-system-task-function]
vendor/google_riscv-dv/src/isa/riscv_vector_instr.sv|396 col 13| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
examples/simple_system/rtl/ibex_simple_system.sv|18 col 11| Macro name does not match the naming convention defined by regex pattern: [A-Z_0-9]+ [Style: defines] [macro-name-style]
vendor/lowrisc_ip/dv/sv/dv_lib/dv_base_env.sv|37 col 101| Line length exceeds max: 100; is: 102 [Style: line-length] [line-length]
vendor/lowrisc_ip/ip/prim/rtl/prim_flop_macros.sv|24 col 101| Line length exceeds max: 100; is: 111 [Style: line-length] [line-length]
vendor/lowrisc_ip/ip/prim/rtl/prim_flop_macros.sv|44 col 101| Line length exceeds max: 100; is: 164 [Style: line-length] [line-length]
vendor/lowrisc_ip/ip/prim/rtl/prim_assert.sv|124 col 101| Line length exceeds max: 100; is: 103 [Style: line-length] [line-length]
vendor/lowrisc_ip/ip/prim/rtl/prim_assert.sv|129 col 101| Line length exceeds max: 100; is: 108 [Style: line-length] [line-length]
vendor/lowrisc_ip/ip/prim/rtl/prim_assert.sv|167 col 101| Line length exceeds max: 100; is: 114 [Style: line-length] [line-length]
dv/uvm/core_ibex/tests/core_ibex_test_lib.sv|1121 col 101| Line length exceeds max: 100; is: 105 [Style: line-length] [line-length]
dv/uvm/core_ibex/tests/core_ibex_test_lib.sv|1281 col 21| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
dv/uvm/core_ibex/tests/core_ibex_test_lib.sv|1525 col 101| Line length exceeds max: 100; is: 104 [Style: line-length] [line-length]
dv/uvm/core_ibex/tests/core_ibex_test_lib.sv|1585 col 101| Line length exceeds max: 100; is: 122 [Style: line-length] [line-length]
dv/uvm/core_ibex/tests/core_ibex_test_lib.sv|1947 col 101| Line length exceeds max: 100; is: 105 [Style: line-length] [line-length]
dv/uvm/icache/dv/ibex_icache_mem_agent/ibex_icache_mem_protocol_checker.sv|13 col 11| Interface name does not match the naming convention defined by regex pattern: [a-z_0-9]+(if) [Style: interface-conventions] [interface-name-style]
vendor/google_riscv-dv/src/isa/riscv_zbb_instr.sv|26 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zbb_instr.sv|97 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zbb_instr.sv|110 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zbb_instr.sv|140 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zbb_instr.sv|155 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zbb_instr.sv|195 col 9| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zbs_instr.sv|42 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zbs_instr.sv|52 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zbs_instr.sv|66 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zbs_instr.sv|82 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zbs_instr.sv|84 col 9| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
dv/uvm/icache/dv/ibex_icache_core_agent/ibex_icache_core_req_item.sv|27 col 14| Constraint names must obey the following regex: ([a-z0-9]+
)+c [Style: constraints] [constraint-name-style]
dv/uvm/icache/dv/ibex_icache_core_agent/ibex_icache_core_req_item.sv|38 col 14| Constraint names must obey the following regex: ([a-z0-9]+
)+c [Style: constraints] [constraint-name-style]
dv/uvm/icache/dv/ibex_icache_core_agent/ibex_icache_core_req_item.sv|45 col 14| Constraint names must obey the following regex: ([a-z0-9]+)+c [Style: constraints] [constraint-name-style]
dv/uvm/icache/dv/ibex_icache_core_agent/ibex_icache_core_req_item.sv|56 col 14| Constraint names must obey the following regex: ([a-z0-9]+
)+c [Style: constraints] [constraint-name-style]
dv/uvm/icache/dv/ibex_icache_core_agent/seq_lib/ibex_icache_core_base_seq.sv|65 col 14| Constraint names must obey the following regex: ([a-z0-9]+)+c [Style: constraints] [constraint-name-style]
dv/uvm/icache/dv/ibex_icache_core_agent/seq_lib/ibex_icache_core_base_seq.sv|72 col 14| Constraint names must obey the following regex: ([a-z0-9]+
)+c [Style: constraints] [constraint-name-style]
vendor/google_riscv-dv/src/isa/riscv_b_instr.sv|32 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_b_instr.sv|110 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_b_instr.sv|128 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_b_instr.sv|193 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_b_instr.sv|247 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_b_instr.sv|269 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_compressed_instr.sv|136 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_compressed_instr.sv|233 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_compressed_instr.sv|333 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_compressed_instr.sv|348 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/lowrisc_ip/dv/sv/csr_utils/csr_seq_lib.sv|380 col 11| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/lowrisc_ip/ip/prim/fpv/tb/prim_keccak_tb.sv|69 col 101| Line length exceeds max: 100; is: 106 [Style: line-length] [line-length]
vendor/google_riscv-dv/src/riscv_privil_reg.sv|28 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/test/riscv_instr_cov_test.sv|67 col 101| Line length exceeds max: 100; is: 103 [Style: line-length] [line-length]
vendor/google_riscv-dv/test/riscv_instr_cov_test.sv|119 col 9| Do not use $test$plusargs to access plusargs, use $value$plusargs instead. [Style: plusarg-value-assignment] [plusarg-assignment]
vendor/google_riscv-dv/src/riscv_pmp_cfg.sv|607 col 101| Line length exceeds max: 100; is: 154 [Style: line-length] [line-length]
dv/uvm/core_ibex/riscv_dv_extension/ibex_directed_instr_lib.sv|354 col 23| Binary literal 32'b10000111 has less digits than expected for 32 bits. [Style: number-literals] [undersized-binary-literal]
dv/riscv_compliance/rtl/riscv_testutil.sv|47 col 14| Explicitly define a storage type for every parameter and localparam, (ADDR_HALT). [Style: constants] [explicit-parameter-storage-type]
dv/riscv_compliance/rtl/riscv_testutil.sv|48 col 14| Explicitly define a storage type for every parameter and localparam, (ADDR_SET_BEGIN_SIGNATURE). [Style: constants] [explicit-parameter-storage-type]
dv/riscv_compliance/rtl/riscv_testutil.sv|49 col 14| Explicitly define a storage type for every parameter and localparam, (ADDR_SET_END_SIGNATURE). [Style: constants] [explicit-parameter-storage-type]
dv/uvm/core_ibex/tests/core_ibex_base_test.sv|72 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
dv/uvm/icache/dv/tb/tb.sv|231 col 101| Line length exceeds max: 100; is: 108 [Style: line-length] [line-length]
vendor/google_riscv-dv/src/isa/riscv_csr_instr.sv|49 col 14| Constraint names must obey the following regex: ([a-z0-9]+)+c [Style: constraints] [constraint-name-style]
vendor/google_riscv-dv/src/isa/riscv_csr_instr.sv|55 col 14| Constraint names must obey the following regex: ([a-z0-9]+
)+c [Style: constraints] [constraint-name-style]
vendor/google_riscv-dv/src/isa/riscv_csr_instr.sv|61 col 14| Constraint names must obey the following regex: ([a-z0-9]+)+c [Style: constraints] [constraint-name-style]
vendor/google_riscv-dv/src/isa/riscv_csr_instr.sv|67 col 14| Constraint names must obey the following regex: ([a-z0-9]+
)+c [Style: constraints] [constraint-name-style]
vendor/google_riscv-dv/src/isa/riscv_csr_instr.sv|112 col 101| Line length exceeds max: 100; is: 136 [Style: line-length] [line-length]
dv/uvm/icache/dv/fcov/ibex_icache_fcov_if.sv|246 col 31| All generate block statements must have a label [Style: generate-statements] [generate-label]
dv/uvm/icache/dv/fcov/ibex_icache_fcov_if.sv|249 col 16| All generate block statements must have a label [Style: generate-statements] [generate-label]
dv/uvm/core_ibex/env/core_ibex_scoreboard.sv|105 col 101| Line length exceeds max: 100; is: 111 [Style: line-length] [line-length]
dv/uvm/core_ibex/env/core_ibex_instr_monitor_if.sv|10 col 13| Explicitly define a storage type for every parameter and localparam, (DATA_WIDTH). [Style: constants] [explicit-parameter-storage-type]
vendor/lowrisc_ip/dv/sv/dv_base_reg/dv_base_reg.sv|142 col 41| 143:90: The lines can't be continued with '', use concatenation operator with braces [Style: forbid-line-continuations] [forbid-line-continuations]
vendor/lowrisc_ip/dv/sv/dv_base_reg/dv_base_reg.sv|151 col 41| 152:83: The lines can't be continued with '', use concatenation operator with braces [Style: forbid-line-continuations] [forbid-line-continuations]
vendor/lowrisc_ip/dv/sv/dv_base_reg/dv_base_reg.sv|161 col 41| 162:84: The lines can't be continued with '', use concatenation operator with braces [Style: forbid-line-continuations] [forbid-line-continuations]
dv/uvm/core_ibex/tb/core_ibex_tb_top.sv|50 col 13| Macro name does not match the naming convention defined by regex pattern: [A-Z_0-9]+ [Style: defines] [macro-name-style]
dv/uvm/core_ibex/tb/core_ibex_tb_top.sv|254 col 101| Line length exceeds max: 100; is: 109 [Style: line-length] [line-length]
vendor/google_riscv-dv/src/riscv_illegal_instr.sv|145 col 14| Constraint names must obey the following regex: ([a-z0-9]+_)+c [Style: constraints] [constraint-name-style]
vendor/google_riscv-dv/src/riscv_load_store_instr_lib.sv|505 col 9| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/riscv_load_store_instr_lib.sv|606 col 101| Line length exceeds max: 100; is: 101 [Style: line-length] [line-length]
vendor/google_riscv-dv/src/riscv_load_store_instr_lib.sv|619 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/riscv_load_store_instr_lib.sv|638 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_instr.sv|283 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_instr.sv|381 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_instr.sv|403 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
dv/uvm/icache/dv/ibex_icache_core_agent/ibex_icache_core_protocol_checker.sv|13 col 11| Interface name does not match the naming convention defined by regex pattern: [a-z_0-9]+(_if) [Style: interface-conventions] [interface-name-style]
vendor/google_riscv-dv/src/isa/riscv_zba_instr.sv|38 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zba_instr.sv|47 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zba_instr.sv|61 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
dv/uvm/core_ibex/fcov/core_ibex_fcov_if.sv|106 col 11| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
dv/uvm/core_ibex/fcov/core_ibex_fcov_if.sv|126 col 9| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
dv/uvm/core_ibex/common/ibex_mem_intf_agent/ibex_mem_intf_response_seq_lib.sv|156 col 101| Line length exceeds max: 100; is: 114 [Style: line-length] [line-length]
vendor/google_riscv-dv/src/isa/riscv_zbc_instr.sv|29 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zbc_instr.sv|38 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/isa/riscv_zbc_instr.sv|47 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
formal/data_ind_timing/formal_tb.sv|29 col 42| Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
formal/data_ind_timing/formal_tb.sv|30 col 42| Unpacked dimension range must be declared in big-endian ([0:N-1]) order. Declare zero-based big-endian unpacked dimensions sized as [N]. [Style: unpacked-ordering] [unpacked-dimensions-range-ordering]
vendor/google_riscv-dv/src/riscv_instr_gen_config.sv|173 col 101| Line length exceeds max: 100; is: 168 [Style: line-length] [line-length]
vendor/google_riscv-dv/src/riscv_instr_gen_config.sv|176 col 101| Line length exceeds max: 100; is: 102 [Style: line-length] [line-length]
vendor/google_riscv-dv/src/riscv_asm_program_gen.sv|450 col 7| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/riscv_asm_program_gen.sv|560 col 5| Explicitly define a default case for every case statement or add unique qualifier to the case statement. [Style: case-statements] [case-missing-default]
vendor/google_riscv-dv/src/riscv_asm_program_gen.sv|586 col 101| Line length exceeds max: 100; is: 105 [Style: line-length] [line-length]
vendor/google_riscv-dv/src/riscv_asm_program_gen.sv|589 col 101| Line length exceeds max: 100; is: 105 [Style: line-length] [line-length]
dv/uvm/core_ibex/common/ibex_mem_intf_agent/ibex_mem_intf.sv|5 col 11| Interface name does not match the naming convention defined by regex pattern: [a-z_0-9]+(_if) [Style: interface-conventions] [interface-name-style]
syn/rtl/prim_clock_gating.v|16 col 3| Use 'always_comb' instead of 'always @*'. [Style: combinational-logic] [always-comb]
dv/uvm/icache/dv/env/ibex_icache_scoreboard.sv|20 col 14| Explicitly define a storage type for every parameter and localparam, (BusWidth). [Style: constants] [explicit-parameter-storage-type]