Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki scraping #84

Open
hahawoo opened this issue Oct 9, 2019 · 4 comments
Open

Wiki scraping #84

hahawoo opened this issue Oct 9, 2019 · 4 comments

Comments

@hahawoo
Copy link
Contributor

hahawoo commented Oct 9, 2019

I've finally made a wiki scraper, which means (ideally) we don't have to manually edit the table anymore.

It's not perfect, for example it doesn't scrape modules for their names and descriptions.

@hahawoo hahawoo mentioned this issue Oct 9, 2019
72 tasks
@rm-code
Copy link
Collaborator

rm-code commented Nov 10, 2019

@hahawoo I just tried updating love-atom and ran into an issue because there is a variant missing for:

name = 'getActiveEffects',

@hahawoo
Copy link
Contributor Author

hahawoo commented Nov 10, 2019

I found 4 functions with no variants using this code:

api = require('love-api.extra')(require('love-api.love_api'))

for i, v in ipairs(api.allfunctions) do
    if #v.variants == 0 then
        print(v.fullname)
    end
end

which found:

love.audio.getActiveEffects
ChainShape:getPoints
PrismaticJoint:setLimitsEnabled
PrismaticJoint:setMotorEnabled

love.audio.getActiveEffects and ChainShape:getPoints were missing the "arguments" section on their wiki pages, so I've fixed the wiki pages.

PrismaticJoint:setLimitsEnabled and PrismaticJoint:setMotorEnabled were an issue with the scraper which I've also now fixed (these functions were both removed/renamed and re-added).

I've updated the table. Hopefully it will work now! :)

@hahawoo
Copy link
Contributor Author

hahawoo commented Nov 18, 2019

KeyConstant isn't currently scraped correctly.

@hahawoo
Copy link
Contributor Author

hahawoo commented Nov 20, 2019

  • I've added the wiki scraper to this repo now.
  • KeyConstant is now retained from the original love-api table when using the scraper, i.e. the scraper will output whatever love-api already has.
  • I accidentally removed love.conf before, it's back now. It is also retained from love-api and not scraped.
  • I've updated the table to 11.3, I'm not sure if it's complete though.
  • The last variant of love.graphics.setCanvas isn't scraped correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants