Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

官网文档中关于fastdep-shiro-jwt的示例代码有点小问题 #30

Open
yindz opened this issue Nov 24, 2021 · 3 comments
Open

官网文档中关于fastdep-shiro-jwt的示例代码有点小问题 #30

yindz opened this issue Nov 24, 2021 · 3 comments

Comments

@yindz
Copy link

yindz commented Nov 24, 2021

您好!
首先感谢您的项目让很多开发者节省了时间,减少了重复代码量。但我看官网文档中建议使用者重写 FastDepShiroJwtAuthorization 类的示例代码是这样的:

@RestControllerAdvice
@ConditionalOnMissingBean(FastDepShiroJwtAuthorization.class)
public class FastDepShiroJwtAuthorization implements FastDepShiroJwtAuthorizationImp {
//... ...
}

而实际上因为 @ConditionalOnMissingBean(FastDepShiroJwtAuthorization.class) 的存在,如果有不太熟悉的开发者原样Copy这块示例代码,则会达不到预期的效果。个人建议这块代码可以稍作修改(或者加一个简要的说明),比如:

@RestControllerAdvice
public class MyFastDepShiroJwtAuthorization extends FastDepShiroJwtAuthorization implements FastDepShiroJwtAuthorizationImp {
//... ...
}```



@qintian95
Copy link

@yindz 官网文档在哪儿呢,没找到

@yindz
Copy link
Author

yindz commented Dec 29, 2021

@yindz 官网文档在哪儿呢,没找到

https://fastdep.louislivi.com/#/module/fastdep-shiro-jwt

@qintian95
Copy link

@yindz 官网文档在哪儿呢,没找到

https://fastdep.louislivi.com/#/module/fastdep-shiro-jwt
好吧我是看集成多数据源的文档,官方只写了配置文件

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants