Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full monitor path in notifications #3798

Closed
1 task done
nennad opened this issue Sep 25, 2023 · 2 comments · Fixed by #3801 · May be fixed by #5485
Closed
1 task done

Full monitor path in notifications #3798

nennad opened this issue Sep 25, 2023 · 2 comments · Fixed by #3801 · May be fixed by #5485
Labels
feature-request Request for new features to be added

Comments

@nennad
Copy link
Contributor

nennad commented Sep 25, 2023

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

Other

🔖 Feature description

Hi there!
When using groups to nest monitors, it would be great if the alarm notification would include the path. It often happens that we have monitors with same names (e.g. "Grafana") but they are nested under different groups (e.g. "Dev", "Stage"...). In such cases based only on the name of the monitor, there's not enough information to know which part of the infrastructure is in question.

✔️ Solution

Including the path here

uptime-kuma/server/model/monitor.js

Line 1257 in bef6a79

let msg = `[${monitor.name}] [${text}] ${bean.msg}`;
would make it more actionable.

❓ Alternatives

No response

📝 Additional Context

No response
@nennad nennad added the feature-request Request for new features to be added label Sep 25, 2023
@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Sep 25, 2023 •
edited
Loading

Related: #3448
As always: Pull Requests welcome ^^.

@nennad
Copy link
Contributor Author

nennad commented Sep 25, 2023

Hey @CommanderStorm thanks, I'll do my best to submit a PR 🍻

@nennad nennad mentioned this issue Oct 12, 2023
Merged
7 tasks
SOwOphie added a commit to SOwOphie/uptime-kuma that referenced this issue Dec 30, 2024
@SOwOphie
Replace monitorJSON.name with monitorJSON.pathName in all notificatio…
4f7cc5d 
…n providers (where applicable)

As noted in louislam#3798, it would be great to have the alarm notification include
the full monitor path.  This was done for Mattermost in louislam#3801, but not for
the other notification providers.  This commit replaces all other trivial
occurences of monitorJSON.name with monitorJSON.pathName.
SOwOphie added a commit to SOwOphie/uptime-kuma that referenced this issue Dec 30, 2024
@SOwOphie
Replace monitorJSON.name with monitorJSON.pathName in all notificatio…
216f39d 
…n providers (where applicable)

As noted in louislam#3798, it would be great to have the alarm notification include
the full monitor path.  This was done for Mattermost in louislam#3801, but not for
the other notification providers.  This commit replaces all other trivial
occurences of monitorJSON.name with monitorJSON.pathName.
@SOwOphie SOwOphie mentioned this issue Dec 30, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Request for new features to be added
Projects
None yet
Milestone
No milestone
2 participants
@nennad @CommanderStorm