Replies: 9 comments
-
|
Laundmo just introduced me to this project and it looks like something I'd definitely be interested in using, but with it using aiohttp as a backend rather than having it as an ASGI compatible app I can run with Uvicorn it's hard for me to justify using it. (This is largely due to the huge number of libraries that do work with Starlette/ASGI apps, such as starlette-discord for Discord OAuth login, for example) |
Beta Was this translation helpful? Give feedback.
-
|
@laundmo, @vcokltfre sounds reasonable. Can you provide a PR that adds ASGI compatibility? |
Beta Was this translation helpful? Give feedback.
-
|
Could you tell us which are the main points where the serverside code interfaces with the library itself? in other words: what classes would we have to replace to fully change out aiophttp as a server? |
Beta Was this translation helpful? Give feedback.
-
|
@laundmo Sure! The only parts that interface with aiohttp directly are |
Beta Was this translation helpful? Give feedback.
-
|
@laundmo, @vcokltfre: Do you guys have code to look at? |
Beta Was this translation helpful? Give feedback.
-
|
@fscherf im sorry to say: no. i've been quite busy and didn't have any time. |
Beta Was this translation helpful? Give feedback.
-
|
@laundmo don't be sorry! :) I just wanted to make sure you are not stuck on something |
Beta Was this translation helpful? Give feedback.
-
|
@laundmo: this issue is open pretty long now. Can i transfer it to the ideas section? |
Beta Was this translation helpful? Give feedback.
-
|
Sure, i doubt I'll be working on it anytime soon.
…On Mon, 9 May 2022, 19:43 Florian Scherf, ***@***.***> wrote:
@laundmo <https://github.com/laundmo>: this issue is open pretty long
now. Can i transfer it to the ideas section?
—
Reply to this email directly, view it on GitHub
<#176 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF5ULDI7MAYK5Y64VPVWYN3VJFFERANCNFSM5HHYBUBQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
Currently, Lona uses aiohttp as a server. Aiohttp server is slower than most ASGI libraries and doesn't use a standardized interface.
What are your thoughts on eventually making this ASGI compatible, so it can run in common ASGI servers like uvicorn?
Im thinking Starlette would be a good option as a server framework, as it's used in FastAPI which is decently well established and proven to be stable and performant.
Beta Was this translation helpful? Give feedback.
All reactions